Re: [U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-11-04 Thread Tom Rini
On Mon, Nov 04, 2019 at 07:07:46PM +0100, Heinrich Schuchardt wrote: > On 10/12/19 3:29 PM, Heinrich Schuchardt wrote: > > On 10/3/19 8:01 PM, Heinrich Schuchardt wrote: > > > On 10/3/19 7:09 PM, Tom Rini wrote: > > > > On Thu, Oct 03, 2019 at 07:01:22PM +0200, Heinrich Schuchardt wrote: > > > >

Re: [U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-11-04 Thread Heinrich Schuchardt
On 10/12/19 3:29 PM, Heinrich Schuchardt wrote: On 10/3/19 8:01 PM, Heinrich Schuchardt wrote: On 10/3/19 7:09 PM, Tom Rini wrote: On Thu, Oct 03, 2019 at 07:01:22PM +0200, Heinrich Schuchardt wrote: struct ip_udp_hdr is naturally packed. There is no point in adding a __packed attribute.

Re: [U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-10-12 Thread Heinrich Schuchardt
On 10/3/19 8:01 PM, Heinrich Schuchardt wrote: On 10/3/19 7:09 PM, Tom Rini wrote: On Thu, Oct 03, 2019 at 07:01:22PM +0200, Heinrich Schuchardt wrote: struct ip_udp_hdr is naturally packed. There is no point in adding a __packed attribute. With the attribute the network stack does not

Re: [U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-10-03 Thread Heinrich Schuchardt
On 10/3/19 7:09 PM, Tom Rini wrote: On Thu, Oct 03, 2019 at 07:01:22PM +0200, Heinrich Schuchardt wrote: struct ip_udp_hdr is naturally packed. There is no point in adding a __packed attribute. With the attribute the network stack does not compile using GCC 9.2.1: net/net.c: In function

Re: [U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-10-03 Thread Tom Rini
On Thu, Oct 03, 2019 at 07:01:22PM +0200, Heinrich Schuchardt wrote: > struct ip_udp_hdr is naturally packed. There is no point in adding a > __packed attribute. With the attribute the network stack does not compile > using GCC 9.2.1: > > net/net.c: In function ‘net_process_received_packet’: >

[U-Boot] [PATCH 1/1] net: remove superfluous __packed attribute

2019-10-03 Thread Heinrich Schuchardt
struct ip_udp_hdr is naturally packed. There is no point in adding a __packed attribute. With the attribute the network stack does not compile using GCC 9.2.1: net/net.c: In function ‘net_process_received_packet’: net/net.c:1288:23: error: taking address of packed member of ‘struct ip_udp_hdr’