Re: [U-Boot] [PATCH 1/1] ubifs: no NULL check needed before free

On 11/21/2017 10:20 AM, Alex Sadovsky wrote: Hi Heinrich and Heiko, do you see anything strange in this code (it was more obvious before the patch but it can still be spotted)? I should say that it's too late to check for "file != NULL" after the "file->private_data" dereference. Maybe it

Re: [U-Boot] [PATCH 1/1] ubifs: no NULL check needed before free

Hi Heinrich and Heiko, do you see anything strange in this code (it was more obvious before the patch but it can still be spotted)? I should say that it's too late to check for "file != NULL" after the "file->private_data" dereference. Maybe it should look like this: if (file)

Re: [U-Boot] [PATCH 1/1] ubifs: no NULL check needed before free

Hello Heinrich, Am 08.11.2017 um 22:28 schrieb Heinrich Schuchardt: kfree() calls free. free() checks if the parameter is NULL. Signed-off-by: Heinrich Schuchardt --- fs/ubifs/ubifs.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) applied to

[U-Boot] [PATCH 1/1] ubifs: no NULL check needed before free

kfree() calls free. free() checks if the parameter is NULL. Signed-off-by: Heinrich Schuchardt --- fs/ubifs/ubifs.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c index 8f1c9d167d..4465523d5f 100644 ---