Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Jim Lin
Thanks for pointing out the potential issue. -Original Message- From: Jon Hunter [mailto:jon-hun...@ti.com] Sent: Thursday, March 21, 2013 7:57 AM To: Jim Lin Cc: u-boot@lists.denx.de; ma...@denx.de; w...@denx.de; tr...@ti.com; Tom Warren Subject: Re: [U-Boot] [PATCH 1/1 v3] console: USB

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Stephen Warren
On 03/20/2013 05:56 PM, Jon Hunter wrote: On 01/24/2013 05:05 AM, Jim Lin wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Wolfgang Denk
Dear Stephen Warren, In message 514aa642.3090...@wwwdotorg.org you wrote: Interesting. I just noticed the same problem, and posted the following patch to fix it: http://lists.denx.de/pipermail/u-boot/2013-March/149625.html This was on the Raspberry Pi. You mean the Raspberry Pi uses

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Jon Hunter
On 03/21/2013 01:57 AM, Wolfgang Denk wrote: Dear Stephen Warren, In message 514aa642.3090...@wwwdotorg.org you wrote: Interesting. I just noticed the same problem, and posted the following patch to fix it: http://lists.denx.de/pipermail/u-boot/2013-March/149625.html This was on the

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Jon Hunter
Hi Marek, On 03/20/2013 07:19 PM, Marek Vasut wrote: Dear Jon Hunter, On 01/24/2013 05:05 AM, Jim Lin wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Wolfgang Denk
Dear Jon Hunter, In message 514b2482.5000...@ti.com you wrote: I understand that you may wish to have SYS_HZ == 1000, but shouldn't the code still normalise the get_timer() value to SYS_HZ? If I grep through the u-boot source I see a lot of instances where get_timer() is normalised to

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-21 Thread Wolfgang Denk
Dear Jon Hunter, In message 514b22fb.1000...@ti.com you wrote: The question is what should get_timer() be returning? If it is meant to be milliseconds then I guess I need to fix get_timer() for my board. However, if it is just meant to be timer ticks at the SYS_HZ rate then I It is ticks

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-20 Thread Jon Hunter
On 01/24/2013 05:05 AM, Jim Lin wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes longer time than 10 ms (e.g., 50 ms) to

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-03-20 Thread Marek Vasut
Dear Jon Hunter, On 01/24/2013 05:05 AM, Jim Lin wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes longer time than 10 ms

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-28 Thread Marek Vasut
Dear Tom Warren, Wolfgang, -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Saturday, January 26, 2013 6:14 AM To: Marek Vasut Cc: Jim Lin; u-boot@lists.denx.de; Tom Warren; tr...@ti.com; albert.u.b...@aribaud.net Subject: Re: [PATCH 1/1 v3] console:

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-28 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/28/2013 11:30 AM, Tom Warren wrote: Wolfgang, -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Saturday, January 26, 2013 6:14 AM To: Marek Vasut Cc: Jim Lin; u-boot@lists.denx.de; Tom Warren; tr...@ti.com;

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-26 Thread Wolfgang Denk
Dear Marek Vasut, In message 201301260417.54768.ma...@denx.de you wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-26 Thread Marek Vasut
Dear Wolfgang Denk, Dear Marek Vasut, In message 201301260417.54768.ma...@denx.de you wrote: Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking

Re: [U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-25 Thread Marek Vasut
Dear Jim Lin, Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes longer time than 10 ms (e.g., 50 ms) to finish. Signed-off-by: Jim

[U-Boot] [PATCH 1/1 v3] console: USB: KBD: Fix incorrect autoboot timeout

2013-01-24 Thread Jim Lin
Autoboot timeout defined by CONFIG_BOOTDELAY will not be accurate if CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL are defined in configuration file and when tstc() function for checking key pressed takes longer time than 10 ms (e.g., 50 ms) to finish. Signed-off-by: Jim Lin ji...@nvidia.com