Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/1 Kumar Gala ga...@kernel.crashing.org: From: Ramneek Mehresh ramneek.mehr...@freescale.com Add UTMI and ULPI PHY support for USB controller on qoriq series of processors with internal UTMI PHY implemented, for example P1010/P1014  - Use both getenv() and hwconfig to get USB phy

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Kumar Gala
On Aug 8, 2011, at 3:15 PM, Remy Bohmer wrote: Hi, 2011/7/1 Kumar Gala ga...@kernel.crashing.org: From: Ramneek Mehresh ramneek.mehr...@freescale.com Add UTMI and ULPI PHY support for USB controller on qoriq series of processors with internal UTMI PHY implemented, for example

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
Hi, The ifdef-ery makes the code somewhat messy as well. Can it be written somewhat else? Apart from that and the style issues, no remarks or concerns. Not really sure how to do that.  The patch is a bit more messy than the actual code. I was talking about the actual code, not the

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-07-17 Thread Kumar Gala
On Jul 11, 2011, at 11:11 AM, Kumar Gala wrote: On Jun 30, 2011, at 11:11 PM, Kumar Gala wrote: From: Ramneek Mehresh ramneek.mehr...@freescale.com Add UTMI and ULPI PHY support for USB controller on qoriq series of processors with internal UTMI PHY implemented, for example P1010/P1014

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-07-11 Thread Kumar Gala
On Jun 30, 2011, at 11:11 PM, Kumar Gala wrote: From: Ramneek Mehresh ramneek.mehr...@freescale.com Add UTMI and ULPI PHY support for USB controller on qoriq series of processors with internal UTMI PHY implemented, for example P1010/P1014 - Use both getenv() and hwconfig to get USB phy

[U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-06-30 Thread Kumar Gala
From: Ramneek Mehresh ramneek.mehr...@freescale.com Add UTMI and ULPI PHY support for USB controller on qoriq series of processors with internal UTMI PHY implemented, for example P1010/P1014 - Use both getenv() and hwconfig to get USB phy type till getenv() is depricated - Introduce