Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-23 Thread Jernej Škrabec
Hi, Dne ponedeljek, 22. januar 2018 ob 19:41:31 CET je Nuno Gonçalves napisal(a): > I have tried for a while to make it work with DM_I2C but so far nothing. I'm not DM I2C expert, but if I recall correctly you have to have I2C child device defined in DT and successfully probed if you want I2C

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-22 Thread Nuno Gonçalves
I have tried for a while to make it work with DM_I2C but so far nothing. => i2c bus Bus -1: i2c@01c2ac00 Bus -1: i2c@01c2b000 => dm tree Class Probed Driver Name root [ + ] root_drive root_driver simple_bus [ + ] generic_si `--

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-22 Thread Nuno Gonçalves
On Fri, Jan 19, 2018 at 9:35 PM, Jernej Škrabec wrote: > Hi, > > Dne petek, 19. januar 2018 ob 19:38:52 CET je Nuno Gonçalves napisal(a): >> Sorry, there is only 1 patch in this series. >> >> I would like comments regarding removing DM_I2C for MACH_SUNXI_H3_H5, >> as I

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-22 Thread Maxime Ripard
On Fri, Jan 19, 2018 at 09:35:58PM +0100, Jernej Škrabec wrote: > Hi, > > Dne petek, 19. januar 2018 ob 19:38:52 CET je Nuno Gonçalves napisal(a): > > Sorry, there is only 1 patch in this series. > > > > I would like comments regarding removing DM_I2C for MACH_SUNXI_H3_H5, > > as I didn't found

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-22 Thread Maxime Ripard
On Fri, Jan 19, 2018 at 07:35:59PM +0100, Nuno Goncalves wrote: > Tested to work in a Orange Pi Zero (H2+/H3), and checked against H5 datasheet. > > Signed-off-by: Nuno Goncalves Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard,

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-19 Thread Nuno Gonçalves
Sorry, there is only 1 patch in this series. I would like comments regarding removing DM_I2C for MACH_SUNXI_H3_H5, as I didn't found a reason for it to be defined. Thanks, Nuno On Fri, Jan 19, 2018 at 7:35 PM, Nuno Goncalves wrote: > Tested to work in a Orange Pi Zero

[U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-19 Thread Nuno Goncalves
Tested to work in a Orange Pi Zero (H2+/H3), and checked against H5 datasheet. Signed-off-by: Nuno Goncalves --- arch/arm/include/asm/arch-sunxi/gpio.h | 2 ++ arch/arm/mach-sunxi/Kconfig| 1 - board/sunxi/board.c| 10 +- 3 files

Re: [U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

2018-01-19 Thread Jernej Škrabec
Hi, Dne petek, 19. januar 2018 ob 19:38:52 CET je Nuno Gonçalves napisal(a): > Sorry, there is only 1 patch in this series. > > I would like comments regarding removing DM_I2C for MACH_SUNXI_H3_H5, > as I didn't found a reason for it to be defined. there is good reason to be there. When H3/H5