Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Ley Foon Tan
On Wed, Aug 28, 2019 at 9:39 PM Marek Vasut wrote: > > On 8/28/19 3:28 PM, Ley Foon Tan wrote: > > [...] > > >>>Tested this on Agilex, look okay. But, pending test on other device > >>> families, like Gen5 or A10. Not sure any side effect with this change. > >>> 2. Secure (for PSCI) and

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Marek Vasut
On 8/28/19 3:28 PM, Ley Foon Tan wrote: [...] >>>Tested this on Agilex, look okay. But, pending test on other device >>> families, like Gen5 or A10. Not sure any side effect with this change. >>> 2. Secure (for PSCI) and non-secure functions share same functions, >>> these functions can't

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Ley Foon Tan
On Wed, Aug 28, 2019 at 8:44 PM Marek Vasut wrote: > > On 8/28/19 10:13 AM, Ley Foon Tan wrote: > [...] > > >> If want to use address from DT, we need get address every time need to > >> use the address. > >> For non-DM, it is easier to use constant address. Let me know if you >

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Simon Goldschmidt
Marek Vasut schrieb am Mi., 28. Aug. 2019, 14:44: > On 8/28/19 10:13 AM, Ley Foon Tan wrote: > [...] > > >> If want to use address from DT, we need get address every time need > to > >> use the address. > >> For non-DM, it is easier to use constant address. Let me know if you >

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Marek Vasut
On 8/28/19 10:13 AM, Ley Foon Tan wrote: [...] >> If want to use address from DT, we need get address every time need to >> use the address. >> For non-DM, it is easier to use constant address. Let me know if you >> still prefer to use address from DT. Surely you can

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-28 Thread Ley Foon Tan
On Fri, Aug 23, 2019 at 5:56 PM Marek Vasut wrote: > > On 8/23/19 11:52 AM, Ley Foon Tan wrote: > > On Fri, Aug 23, 2019 at 5:23 PM Marek Vasut wrote: > >> > >> On 8/23/19 10:57 AM, Ley Foon Tan wrote: > >>> On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan > >>> wrote: > > On Tue, Aug

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-26 Thread Simon Goldschmidt
Marek Vasut schrieb am Mo., 26. Aug. 2019, 10:50: > On 8/26/19 9:28 AM, Ley Foon Tan wrote: > [...] > >> If want to use address from DT, we need get address every time need > to > >> use the address. > >> For non-DM, it is easier to use constant address. Let me know if you > >>

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-26 Thread Marek Vasut
On 8/26/19 9:28 AM, Ley Foon Tan wrote: [...] >> If want to use address from DT, we need get address every time need to >> use the address. >> For non-DM, it is easier to use constant address. Let me know if you >> still prefer to use address from DT. Surely you can cache

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-26 Thread Ley Foon Tan
On Fri, Aug 23, 2019 at 5:56 PM Marek Vasut wrote: > > On 8/23/19 11:52 AM, Ley Foon Tan wrote: > > On Fri, Aug 23, 2019 at 5:23 PM Marek Vasut wrote: > >> > >> On 8/23/19 10:57 AM, Ley Foon Tan wrote: > >>> On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan > >>> wrote: > > On Tue, Aug

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-23 Thread Marek Vasut
On 8/23/19 11:52 AM, Ley Foon Tan wrote: > On Fri, Aug 23, 2019 at 5:23 PM Marek Vasut wrote: >> >> On 8/23/19 10:57 AM, Ley Foon Tan wrote: >>> On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan wrote: On Tue, Aug 20, 2019 at 5:50 PM Marek Vasut wrote: > > On 8/20/19 4:35 AM, Ley

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-23 Thread Ley Foon Tan
On Fri, Aug 23, 2019 at 5:23 PM Marek Vasut wrote: > > On 8/23/19 10:57 AM, Ley Foon Tan wrote: > > On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan wrote: > >> > >> On Tue, Aug 20, 2019 at 5:50 PM Marek Vasut wrote: > >>> > >>> On 8/20/19 4:35 AM, Ley Foon Tan wrote: > Convert reset manager

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-23 Thread Marek Vasut
On 8/23/19 10:57 AM, Ley Foon Tan wrote: > On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan wrote: >> >> On Tue, Aug 20, 2019 at 5:50 PM Marek Vasut wrote: >>> >>> On 8/20/19 4:35 AM, Ley Foon Tan wrote: Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct to defines.

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-23 Thread Ley Foon Tan
On Wed, Aug 21, 2019 at 9:50 AM Ley Foon Tan wrote: > > On Tue, Aug 20, 2019 at 5:50 PM Marek Vasut wrote: > > > > On 8/20/19 4:35 AM, Ley Foon Tan wrote: > > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > > > to defines. > > > No functional change. > > > > > >

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Ley Foon Tan
On Tue, Aug 20, 2019 at 7:24 PM Marek Vasut wrote: > > On 8/20/19 12:29 PM, Simon Goldschmidt wrote: > > > > > > Marek Vasut mailto:ma...@denx.de>> schrieb am Di., 20. > > Aug. 2019, 12:15: > > > > On 8/20/19 11:55 AM, Simon Goldschmidt wrote: > > > > > > > > > Marek Vasut

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Ley Foon Tan
On Tue, Aug 20, 2019 at 5:50 PM Marek Vasut wrote: > > On 8/20/19 4:35 AM, Ley Foon Tan wrote: > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > No functional change. > > > > Signed-off-by: Ley Foon Tan > > --- > >

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Marek Vasut
On 8/20/19 12:29 PM, Simon Goldschmidt wrote: > > > Marek Vasut mailto:ma...@denx.de>> schrieb am Di., 20. > Aug. 2019, 12:15: > > On 8/20/19 11:55 AM, Simon Goldschmidt wrote: > > > > > > Marek Vasut mailto:ma...@denx.de> > >>

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Simon Goldschmidt
Marek Vasut schrieb am Di., 20. Aug. 2019, 12:15: > On 8/20/19 11:55 AM, Simon Goldschmidt wrote: > > > > > > Marek Vasut mailto:ma...@denx.de>> schrieb am Di., 20. > > Aug. 2019, 11:50: > > > > On 8/20/19 4:35 AM, Ley Foon Tan wrote: > > > Convert reset manager for Gen5, Arria 10 and

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Marek Vasut
On 8/20/19 11:55 AM, Simon Goldschmidt wrote: > > > Marek Vasut mailto:ma...@denx.de>> schrieb am Di., 20. > Aug. 2019, 11:50: > > On 8/20/19 4:35 AM, Ley Foon Tan wrote: > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > No functional

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Simon Goldschmidt
Marek Vasut schrieb am Di., 20. Aug. 2019, 11:50: > On 8/20/19 4:35 AM, Ley Foon Tan wrote: > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > No functional change. > > > > Signed-off-by: Ley Foon Tan > > --- > >

Re: [U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-20 Thread Marek Vasut
On 8/20/19 4:35 AM, Ley Foon Tan wrote: > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. > No functional change. > > Signed-off-by: Ley Foon Tan > --- > .../mach-socfpga/include/mach/reset_manager.h | 12 + > .../include/mach/reset_manager_arria10.h |

[U-Boot] [PATCH 1/3] arm: socfpga: Convert reset manager from struct to defines

2019-08-19 Thread Ley Foon Tan
Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct to defines. No functional change. Signed-off-by: Ley Foon Tan --- .../mach-socfpga/include/mach/reset_manager.h | 12 + .../include/mach/reset_manager_arria10.h | 41 +++-