Re: [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files

2015-01-21 Thread Graeme Russ
On 22/01/15 10:24, Marek Vasut wrote: On Wednesday, January 21, 2015 at 12:55:14 PM, Graeme Russ wrote: Signed-off-by: Graeme Russ Hi! - Commit message is missing. - Some of the debug outputs are missing newline (\n) character - You can use __func__ and __LINE__ in the debug output to bett

Re: [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files

2015-01-21 Thread Marek Vasut
On Wednesday, January 21, 2015 at 12:55:14 PM, Graeme Russ wrote: > Signed-off-by: Graeme Russ Hi! - Commit message is missing. - Some of the debug outputs are missing newline (\n) character - You can use __func__ and __LINE__ in the debug output to better specify where the debug spit happened

Re: [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files

2015-01-21 Thread Fabio Estevam
On Wed, Jan 21, 2015 at 9:55 AM, Graeme Russ wrote: > Signed-off-by: Graeme Russ In the subject I guess you meant 'mxs' instead of mx29. Also, if you send a v2, please keep Marek on Cc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

[U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files

2015-01-21 Thread Graeme Russ
Signed-off-by: Graeme Russ --- arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 1 + arch/arm/cpu/arm926ejs/mxs/spl_lradc_init.c | 13 +++- arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 18 + arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 100 +++- 4 files changed, 12