Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-20 Thread David Gibson
On Fri, Jan 18, 2013 at 06:59:46AM -0500, Gerald Van Baren wrote: On 01/17/2013 06:50 PM, David Gibson wrote: On Thu, Jan 17, 2013 at 01:32:45PM -0500, Jerry Van Baren wrote: Hi Scott, Kim, David, [snip] libfdt_env.h is where Kim typedef'ed fdt16_t, fdt32_t, fdt64_t I suspect the

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-18 Thread Jerry Van Baren
Hi Kim, On 01/16/2013 06:59 PM, Kim Phillips wrote: and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h before libfdt.h. this is needed to get the fdt type definitions set from the project environment before fdt.h uses them. Signed-off-by: Kim

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-18 Thread Gerald Van Baren
On 01/17/2013 06:50 PM, David Gibson wrote: On Thu, Jan 17, 2013 at 01:32:45PM -0500, Jerry Van Baren wrote: Hi Scott, Kim, David, [snip] libfdt_env.h is where Kim typedef'ed fdt16_t, fdt32_t, fdt64_t I suspect the original intent was to have libfdt.h be the file that people #included.

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-17 Thread Kim Phillips
On Wed, 16 Jan 2013 18:36:03 -0600 Scott Wood scottw...@freescale.com wrote: On 01/16/2013 05:59:04 PM, Kim Phillips wrote: and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h before libfdt.h. this is needed to get the fdt type definitions

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-17 Thread Jerry Van Baren
Hi Scott, Kim, David, On 01/17/2013 12:54 PM, Kim Phillips wrote: On Wed, 16 Jan 2013 18:36:03 -0600 Scott Wood scottw...@freescale.com wrote: On 01/16/2013 05:59:04 PM, Kim Phillips wrote: and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-17 Thread David Gibson
On Thu, Jan 17, 2013 at 01:32:45PM -0500, Jerry Van Baren wrote: Hi Scott, Kim, David, On 01/17/2013 12:54 PM, Kim Phillips wrote: On Wed, 16 Jan 2013 18:36:03 -0600 Scott Wood scottw...@freescale.com wrote: On 01/16/2013 05:59:04 PM, Kim Phillips wrote: and, if including libfdt.h which

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-17 Thread David Gibson
On Thu, Jan 17, 2013 at 11:54:56AM -0600, Kim Phillips wrote: On Wed, 16 Jan 2013 18:36:03 -0600 Scott Wood scottw...@freescale.com wrote: On 01/16/2013 05:59:04 PM, Kim Phillips wrote: and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h

[U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-16 Thread Kim Phillips
and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h before libfdt.h. this is needed to get the fdt type definitions set from the project environment before fdt.h uses them. Signed-off-by: Kim Phillips kim.phill...@freescale.com Cc: Jerry Van Baren

Re: [U-Boot] [PATCH 1/5] treewide: include libfdt_env.h before fdt.h

2013-01-16 Thread Scott Wood
On 01/16/2013 05:59:04 PM, Kim Phillips wrote: and, if including libfdt.h which includes libfdt_env.h in the correct order, don't include fdt.h before libfdt.h. this is needed to get the fdt type definitions set from the project environment before fdt.h uses them. Signed-off-by: Kim Phillips