Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-18 Thread Simon Glass
Hi Tom, On Thu, Sep 13, 2012 at 2:10 PM, Tom Warren twarren.nvi...@gmail.com wrote: Tom, On Thu, Sep 13, 2012 at 11:06 AM, Tom Rini tr...@ti.com wrote: On Wed, Sep 12, 2012 at 03:10:47PM -0700, Tom Warren wrote: Signed-off-by: Tom Warren twar...@nvidia.com A few things: - I see some

Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-18 Thread Tom Warren
Simon, On Tue, Sep 18, 2012 at 12:29 PM, Simon Glass s...@chromium.org wrote: Hi Tom, On Thu, Sep 13, 2012 at 2:10 PM, Tom Warren twarren.nvi...@gmail.com wrote: Tom, On Thu, Sep 13, 2012 at 11:06 AM, Tom Rini tr...@ti.com wrote: On Wed, Sep 12, 2012 at 03:10:47PM -0700, Tom Warren wrote:

Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-13 Thread Tom Rini
On Wed, Sep 12, 2012 at 03:10:47PM -0700, Tom Warren wrote: Signed-off-by: Tom Warren twar...@nvidia.com A few things: - I see some #define FOO[space][space]val that should be [tab] - I didn't checkpatch.pl this (nor the whole series) but please do and let us know if it's clean or why the

Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-13 Thread Stephen Warren
On 09/12/2012 04:10 PM, Tom Warren wrote: Signed-off-by: Tom Warren twar...@nvidia.com Hmm. This is rather large to review, but I tried to at least glance through it all and spot obvious issues... diff --git a/arch/arm/include/asm/arch-tegra30/ap30.h

Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-13 Thread Tom Warren
Stephen, On Thu, Sep 13, 2012 at 12:35 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 09/12/2012 04:10 PM, Tom Warren wrote: Signed-off-by: Tom Warren twar...@nvidia.com Hmm. This is rather large to review, but I tried to at least glance through it all and spot obvious issues... diff

Re: [U-Boot] [PATCH 1/9] Tegra: T30: Add include files

2012-09-13 Thread Tom Warren
Tom, On Thu, Sep 13, 2012 at 11:06 AM, Tom Rini tr...@ti.com wrote: On Wed, Sep 12, 2012 at 03:10:47PM -0700, Tom Warren wrote: Signed-off-by: Tom Warren twar...@nvidia.com A few things: - I see some #define FOO[space][space]val that should be [tab] Probably copied over from Tegra20 files.