Re: [U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability

2012-02-03 Thread Mike Frysinger
On Tuesday 24 January 2012 01:19:14 Simon Glass wrote: > On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote: > > Rename parameter len to payload_len in NetSendUDPPacket: this name > > more explicitly claims that it does not include the header size > > Rename CDPHandler to CDPReceive: this is

Re: [U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability

2012-02-03 Thread Mike Frysinger
On Thursday 19 January 2012 19:53:13 Joe Hershberger wrote: > --- a/include/net.h > +++ b/include/net.h > > -#define E802_HDR_SIZE22 /* 802 ethernet header size > */ > + /* 802.2 + SNAP + ethernet header size */ > +#define E802_HDR_SIZE

Re: [U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability

2012-01-23 Thread Simon Glass
Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote: > Rename parameter len to payload_len in NetSendUDPPacket: this name >   more explicitly claims that it does not include the header size > Rename CDPHandler to CDPReceive: this is not called as a handler, >   so don't name it that wa

[U-Boot] [PATCH 10/28] net: cosmetic: Improve variable names and code readability

2012-01-20 Thread Joe Hershberger
Rename parameter len to payload_len in NetSendUDPPacket: this name more explicitly claims that it does not include the header size Rename CDPHandler to CDPReceive: this is not called as a handler, so don't name it that way Rename OPT_SIZE to OPT_FIELD_SIZE: clearer constant name and also r