Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Stefano Babic
On 28/11/2011 17:37, Ilya Yanok wrote: Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. I can't see any way to determine some safe address automagically so make it up to board porter to provide the safe-to-use address via

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Ilya Yanok
Hi Stefano, On 07.12.2011 13:06, Stefano Babic wrote: +#ifndef CONFIG_SPL_NAND_WORKSPACE +#define CONFIG_SPL_NAND_WORKSPACE (CONFIG_SYS_SDRAM_BASE + 0x1) +#endif Maybe it is better to not have a default value somewhere in the SDRAM and to get a compile error. If we do not want to fix

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Scott Wood
On 12/07/2011 11:46 AM, Ilya Yanok wrote: Hi Stefano, On 07.12.2011 13:06, Stefano Babic wrote: +#ifndef CONFIG_SPL_NAND_WORKSPACE +#define CONFIG_SPL_NAND_WORKSPACE (CONFIG_SYS_SDRAM_BASE + 0x1) +#endif Maybe it is better to not have a default value somewhere in the SDRAM and to

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Wolfgang Denk
Dear Ilya Yanok, In message 4edfa65e.8080...@emcraft.com you wrote: boards, we could at least use a #warn message to advise at compile time that a default value is taken (and at the end, to force the board maintainers to fix it...). Probably. Wolfgang, Scott, do you think we should add

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Ilya Yanok
Dear Wolfgang, On 07.12.2011 22:45, Wolfgang Denk wrote: boards, we could at least use a #warn message to advise at compile time that a default value is taken (and at the end, to force the board maintainers to fix it...). Probably. Wolfgang, Scott, do you think we should add a warning here?

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-12-07 Thread Stefano Babic
On 07/12/2011 19:45, Wolfgang Denk wrote: Dear Ilya Yanok, In message 4edfa65e.8080...@emcraft.com you wrote: boards, we could at least use a #warn message to advise at compile time that a default value is taken (and at the end, to force the board maintainers to fix it...). Probably.

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-11-30 Thread Igor Grinberg
Hi Ilya, On 11/28/11 18:37, Ilya Yanok wrote: Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. I can't see any way to determine some safe address automagically so make it up to board porter to provide the safe-to-use

Re: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-11-29 Thread Scott Wood
On 11/28/2011 10:37 AM, Ilya Yanok wrote: Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. I can't see any way to determine some safe address automagically so make it up to board porter to provide the safe-to-use address

[U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-11-28 Thread Ilya Yanok
Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. I can't see any way to determine some safe address automagically so make it up to board porter to provide the safe-to-use address via CONFIG_SPL_NAND_WORKSPACE value.

[U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE

2011-11-10 Thread Ilya Yanok
Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. I can't see any way to determine some safe address automagically so make it up to board porter to provide the safe-to-use address via CONFIG_SPL_NAND_WORKSPACE value.