Re: [U-Boot] [PATCH 2/2] at91_emac: Write MAC address automatically

2010-06-21 Thread Eric Bénard
Hi Ben, Le 21/06/2010 07:59, Ben Warren a écrit : > On 6/15/2010 5:36 AM, Eric Bénard wrote: >> + >> +if (netdev->enetaddr != 0) { >> > This check's not necessary. The caller checks if the MAC address is > valid ( a more extensive check than you do here) OK, fixed patch sent, thanks. Eric _

Re: [U-Boot] [PATCH 2/2] at91_emac: Write MAC address automatically

2010-06-20 Thread Ben Warren
Hi Eric, On 6/15/2010 5:36 AM, Eric Bénard wrote: > tested on cpuat91. > > Signed-off-by: Eric Bénard > --- > drivers/net/at91_emac.c | 31 +++ > 1 files changed, 23 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/at91_emac.c b/drivers/net/at91_emac.c >

[U-Boot] [PATCH 2/2] at91_emac: Write MAC address automatically

2010-06-15 Thread Eric Bénard
tested on cpuat91. Signed-off-by: Eric Bénard --- drivers/net/at91_emac.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/net/at91_emac.c b/drivers/net/at91_emac.c index 1ebcf05..ac5903d 100644 --- a/drivers/net/at91_emac.c +++ b/dr