Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-18 Thread Marek Vasut
On Sunday 16 January 2011 16:21:34 Stefano Babic wrote: On 01/13/2011 06:27 PM, Marek Vasut wrote: As for the PMIC, other boards don't use any #defines for those constants either, which obviously doens't mean it's right. Well, this is not true. You use in yourd board a lot of these

Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-18 Thread Wolfgang Denk
Dear Marek Vasut, In message 201101182032.33444.marek.va...@gmail.com you wrote: +/*** *** I have not checked before, but this is not the coding style for multiline comments. Well it's more of a section

Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-16 Thread Stefano Babic
On 01/13/2011 06:27 PM, Marek Vasut wrote: As for the PMIC, other boards don't use any #defines for those constants either, which obviously doens't mean it's right. Well, this is not true. You use in yourd board a lot of these constants. There are only a few of them that are not used and +

[U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-13 Thread Marek Vasut
Supported: MMC IDE PMIC SPI flash LEDs I can boot the kernel supplied by freescale/genesi with this from MMC card and/or PATA disk. Signed-off-by: Marek Vasut marek.va...@gmail.com --- v2: Fixed line-too-long, MAINTAINERs etc. (I hope everything but the PMIC*) bugs as proposed by Stefano. As