Re: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

2015-05-15 Thread Hans de Goede
Hi, On 14-05-15 20:41, Ian Campbell wrote: On Thu, 2015-05-14 at 18:55 +0200, Hans de Goede wrote: +config DRAM_ODT_EN + int sunxi dram odt enable + default 0 + ---help--- + Set this to 1 to enable dram odt (on die termination) Why is this an int rather than a bool?

Re: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

2015-05-14 Thread Ian Campbell
On Thu, 2015-05-14 at 18:55 +0200, Hans de Goede wrote: +config DRAM_ODT_EN + int sunxi dram odt enable + default 0 + ---help--- + Set this to 1 to enable dram odt (on die termination) Why is this an int rather than a bool? Because it is used directly as an int in the code,

Re: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

2015-05-14 Thread Hans de Goede
Hi, On 05/13/2015 09:26 PM, Ian Campbell wrote: On Wed, 2015-05-13 at 17:09 +0200, Hans de Goede wrote: diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 940b6c7..d4ae6c7 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -95,6 +95,14 @@ config DRAM_ZQ ---help---

[U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

2015-05-13 Thread Hans de Goede
Some A33 based boards use odt, while others do not, so make this configurable. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c | 3 +-- board/sunxi/Kconfig | 8 2 files changed, 9 insertions(+), 2 deletions(-) diff

Re: [U-Boot] [PATCH 2/2] sunxi: Make dram odt-en configurable through Kconfig for A33 based boards

2015-05-13 Thread Ian Campbell
On Wed, 2015-05-13 at 17:09 +0200, Hans de Goede wrote: diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 940b6c7..d4ae6c7 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -95,6 +95,14 @@ config DRAM_ZQ ---help--- Set the dram zq value. +if