Re: [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

2016-08-08 Thread Stefan Roese
Hi Simon, On 08.08.2016 23:44, Simon Glass wrote: On 8 August 2016 at 08:45, Heiko Schocher wrote: Hello Simon, Am 07.08.2016 um 08:54 schrieb Bin Meng: On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass wrote: If intel_i2c_bind() is called before relocation

Re: [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

2016-08-08 Thread Simon Glass
Hi Heiko, On 8 August 2016 at 08:45, Heiko Schocher wrote: > Hello Simon, > > > Am 07.08.2016 um 08:54 schrieb Bin Meng: >> >> On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass wrote: >>> >>> If intel_i2c_bind() is called before relocation there is no BSS section >>>

Re: [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

2016-08-08 Thread Heiko Schocher
Hello Simon, Am 07.08.2016 um 08:54 schrieb Bin Meng: On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass wrote: If intel_i2c_bind() is called before relocation there is no BSS section available. Use the data section instead, which is always available. A better fix might be to

Re: [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

2016-08-07 Thread Bin Meng
On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass wrote: > If intel_i2c_bind() is called before relocation there is no BSS section > available. Use the data section instead, which is always available. > > A better fix might be to use global_data, perhaps a new member in > x86's

[U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

2016-08-05 Thread Simon Glass
If intel_i2c_bind() is called before relocation there is no BSS section available. Use the data section instead, which is always available. A better fix might be to use global_data, perhaps a new member in x86's struct arch_global_data. Comments welcome. Signed-off-by: Simon Glass