Re: [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

2009-06-12 Thread Wolfgang Denk
Dear Stefan Roese, In message 1244115339-19862-2-git-send-email...@denx.de you wrote: This command is used to load/boot an OS-image which is transferred from the CPCI host to the CPCI target/adapter. Signed-off-by: Stefan Roese s...@denx.de Cc: Reinhard Arlt

Re: [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

2009-06-05 Thread Matthias Fuchs
Hi Stefan, please leave the code as is. It is already used in a project and so modifying the parameter type may no change. On Friday 05 June 2009 05:39, Stefan Roese wrote: Hi Matthias, On Thursday 04 June 2009 19:40:19 Matthias Fuchs wrote: doen't it make sense to use/extend the code from

[U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

2009-06-04 Thread Stefan Roese
This command is used to load/boot an OS-image which is transferred from the CPCI host to the CPCI target/adapter. Signed-off-by: Stefan Roese s...@denx.de Cc: Reinhard Arlt reinhard.a...@esd-electronics.com --- board/esd/cpci750/cpci750.c | 76 +++ 1

Re: [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

2009-06-04 Thread Matthias Fuchs
Hi Stefan, doen't it make sense to use/extend the code from board/esd/common/cmd_loadpci.c in stead it copying this code? Even that code is running on 4xx only, it should be simple to modify it for cpci750. Adding support for bootvx should be simple also. Matthias This command is used to

Re: [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

2009-06-04 Thread Stefan Roese
Hi Matthias, On Thursday 04 June 2009 19:40:19 Matthias Fuchs wrote: doen't it make sense to use/extend the code from board/esd/common/cmd_loadpci.c in stead it copying this code? Even that code is running on 4xx only, it should be simple to modify it for cpci750. Adding support for bootvx