Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-23 Thread Kumar Gala
On Sep 22, 2009, at 3:05 PM, Wolfgang Denk wrote: Dear Kumar Gala, In message 1253307595-28655-3-git-send-email-ga...@kernel.crashing.org you wrote: On CoreNet based platforms the LAW address is split between an high low register and we no longer shift the address. Also, the target

Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-22 Thread Wolfgang Denk
Dear Kumar Gala, In message 1253307595-28655-3-git-send-email-ga...@kernel.crashing.org you wrote: On CoreNet based platforms the LAW address is split between an high low register and we no longer shift the address. Also, the target IDs on CoreNet platforms have been completely re-assigned.

[U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-18 Thread Kumar Gala
On CoreNet based platforms the LAW address is split between an high low register and we no longer shift the address. Also, the target IDs on CoreNet platforms have been completely re-assigned. Additionally, added a new find_law() API to which LAW an address hits in. This is need for the CoreNet

Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-18 Thread Scott Wood
Kumar Gala wrote: void set_law(u8 idx, phys_addr_t addr, enum law_size sz, enum law_trgt_if id) { +#ifdef CONFIG_FSL_CORENET + volatile ccsr_local_t *ccm; + volatile u32 *base, *lawbarh, *lawbarl, *lawar; We don't really need the volatile... void disable_law(u8 idx) { +#ifdef

Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-18 Thread Scott Wood
Scott Wood wrote: +base = (ccm-lawbarh0); Use in_be32(). Likewise in find_law. Grr, ignore me. I just had my brain baked by an ISO9000 presentation. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-18 Thread Ben Warren
Scott Wood wrote: Scott Wood wrote: +base = (ccm-lawbarh0); Use in_be32(). Likewise in find_law. Grr, ignore me. I just had my brain baked by an ISO9000 presentation. You should always just go home after those things. Let someone else drive, though :) Ben

Re: [U-Boot] [PATCH 2/7] ppc/p4080: Add support for CoreNet style platform LAWs

2009-09-18 Thread Kumar Gala
On Sep 18, 2009, at 4:55 PM, Scott Wood wrote: +#ifdef CONFIG_FSL_CORENET +volatile ccsr_local_t *ccm; +volatile u32 *base, *lawbarh, *lawbarl, *lawar; + +ccm = (void *)(CONFIG_SYS_FSL_CORENET_CCM_ADDR); + +base = (ccm-lawbarh0); +