Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-22 Thread Joe Hershberger
On Sun, Jan 17, 2016 at 3:51 PM, Simon Glass wrote: > We should avoid weak functions with driver model. Existing boards that use > driver model don't need them, so let's kill them off. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boo

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-22 Thread Joe Hershberger
On Sun, Jan 17, 2016 at 10:29 PM, Bin Meng wrote: > Hi Simon, > > On Mon, Jan 18, 2016 at 11:58 AM, Simon Glass wrote: >> Hi Bin, >> >> On 17 January 2016 at 20:25, Bin Meng wrote: >>> Hi Simon, >>> >>> On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: We should avoid weak functions with

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 11:58 AM, Simon Glass wrote: > Hi Bin, > > On 17 January 2016 at 20:25, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: >>> We should avoid weak functions with driver model. Existing boards that use >>> driver model don't

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Simon Glass
Hi Bin, On 17 January 2016 at 20:25, Bin Meng wrote: > Hi Simon, > > On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: >> We should avoid weak functions with driver model. Existing boards that use >> driver model don't need them, so let's kill them off. >> >> Signed-off-by: Simon Glass >> ---

Re: [U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Bin Meng
Hi Simon, On Mon, Jan 18, 2016 at 5:51 AM, Simon Glass wrote: > We should avoid weak functions with driver model. Existing boards that use > driver model don't need them, so let's kill them off. > > Signed-off-by: Simon Glass > --- > > net/eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

[U-Boot] [PATCH 2/8] net: Don't call board/cpu_eth_init() with driver model

2016-01-17 Thread Simon Glass
We should avoid weak functions with driver model. Existing boards that use driver model don't need them, so let's kill them off. Signed-off-by: Simon Glass --- net/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index 45fe6e3..d96d3a5 100644 -