Re: [U-Boot] [PATCH 3/3] Remove includes and PRI* usages in printf() entirely

2018-08-06 Thread Masahiro Yamada
2018-08-06 22:20 GMT+09:00 Andy Shevchenko : > On Mon, Aug 6, 2018 at 2:47 PM, Masahiro Yamada > wrote: > >> The use of PRI* makes the code super-ugly. You can simply use >> "l" for printing uintptr_t, "ll" for u64, and no modifier for u32. > > This is not always the case. I dunno what exact

Re: [U-Boot] [PATCH 3/3] Remove includes and PRI* usages in printf() entirely

2018-08-06 Thread Andy Shevchenko
On Mon, Aug 6, 2018 at 2:47 PM, Masahiro Yamada wrote: > The use of PRI* makes the code super-ugly. You can simply use > "l" for printing uintptr_t, "ll" for u64, and no modifier for u32. This is not always the case. I dunno what exact usage of PRIx in U-Boot, but this is correct way for some

[U-Boot] [PATCH 3/3] Remove includes and PRI* usages in printf() entirely

2018-08-06 Thread Masahiro Yamada
In int-ll64.h, we always use the following typedefs: typedef unsigned int u32; typedef unsigned longuintptr_t; typedef unsigned long long u64; This does not need to match to the compiler's . Do not include it. The use of PRI* makes the code super-ugly. You can simply