Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-21 Thread Igor Grinberg
On 08/20/12 21:27, Stephen Warren wrote: > On 08/20/2012 06:41 AM, Lucas Stach wrote: >> Hello Igor, >> >> thanks for your review. Comments inline. >> >> Am Montag, den 20.08.2012, 15:07 +0300 schrieb Igor Grinberg: >>> Hi Lucas, >>> >>> On 08/19/12 19:08, Lucas Stach wrote: This adds the re

Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-21 Thread Igor Grinberg
On 08/20/12 15:41, Lucas Stach wrote: > Hello Igor, > > thanks for your review. Comments inline. > > Am Montag, den 20.08.2012, 15:07 +0300 schrieb Igor Grinberg: >> Hi Lucas, >> >> On 08/19/12 19:08, Lucas Stach wrote: >>> This adds the required code to set up a ULPI USB port. It is >>> mostly a

Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-20 Thread Stephen Warren
On 08/20/2012 06:41 AM, Lucas Stach wrote: > Hello Igor, > > thanks for your review. Comments inline. > > Am Montag, den 20.08.2012, 15:07 +0300 schrieb Igor Grinberg: >> Hi Lucas, >> >> On 08/19/12 19:08, Lucas Stach wrote: >>> This adds the required code to set up a ULPI USB port. It is >>> mos

Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-20 Thread Stephen Warren
On 08/19/2012 10:08 AM, Lucas Stach wrote: > This adds the required code to set up a ULPI USB port. It is > mostly a port of the Linux ULPI setup code with some tweaks > added for more correctness, discovered along the way of > debugging this. > > To use this both CONFIG_USB_ULPI and CONFIG_USB_UL

Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-20 Thread Lucas Stach
Hello Igor, thanks for your review. Comments inline. Am Montag, den 20.08.2012, 15:07 +0300 schrieb Igor Grinberg: > Hi Lucas, > > On 08/19/12 19:08, Lucas Stach wrote: > > This adds the required code to set up a ULPI USB port. It is > > mostly a port of the Linux ULPI setup code with some tweak

Re: [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-20 Thread Igor Grinberg
Hi Lucas, On 08/19/12 19:08, Lucas Stach wrote: > This adds the required code to set up a ULPI USB port. It is > mostly a port of the Linux ULPI setup code with some tweaks > added for more correctness, discovered along the way of > debugging this. Can you share which tweaks for correctness are t

[U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code

2012-08-19 Thread Lucas Stach
This adds the required code to set up a ULPI USB port. It is mostly a port of the Linux ULPI setup code with some tweaks added for more correctness, discovered along the way of debugging this. To use this both CONFIG_USB_ULPI and CONFIG_USB_ULPI_VIEWPORT have to be set in the board configuration f