Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

Hi Stephen, On Tue, 13 Mar 2018 at 17:22 Stephen Warren wrote: > On 03/03/2018 09:32 AM, Liam Beguin wrote: > > On 1 March 2018 at 16:56, Stephen Warren wrote: > >> On 02/26/2018 09:17 PM, Liam Beguin wrote: > >>> > >>> Add basic tests for the

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 03/03/2018 09:32 AM, Liam Beguin wrote: On 1 March 2018 at 16:56, Stephen Warren wrote: On 02/26/2018 09:17 PM, Liam Beguin wrote: Add basic tests for the spi_flash subsystem. diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_sf.py +import re

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 1.3.2018 22:18, Stephen Warren wrote: > On 03/01/2018 04:48 AM, Liam Beguin wrote: >> On 1 March 2018 at 01:59, Michal Simek wrote: > ... >>> Also these randomized data/lengths were able to find out more issues >>> than fixed one. I was playing with that randomized

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 1 March 2018 at 16:56, Stephen Warren wrote: > On 02/26/2018 09:17 PM, Liam Beguin wrote: >> >> Add basic tests for the spi_flash subsystem. > > >> diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_sf.py > > >> +import re >> +import pytest >> +import

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 02/26/2018 09:17 PM, Liam Beguin wrote: Add basic tests for the spi_flash subsystem. diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_sf.py +import re +import pytest +import u_boot_utils + + Nit: Double blank line. The same issue exists in many other places too. +"""

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 03/01/2018 04:48 AM, Liam Beguin wrote: On 1 March 2018 at 01:59, Michal Simek wrote: ... Also these randomized data/lengths were able to find out more issues than fixed one. I was playing with that randomized test order and I see that not all current tests are

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 1.3.2018 12:48, Liam Beguin wrote: > On 1 March 2018 at 01:59, Michal Simek wrote: >> On 1.3.2018 05:01, Liam Beguin wrote: >>> Hi Michal, >>> >>> On 27 February 2018 at 03:51, Michal Simek wrote: Hi Liam, On 27.2.2018 05:17,

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 1 March 2018 at 01:59, Michal Simek wrote: > On 1.3.2018 05:01, Liam Beguin wrote: >> Hi Michal, >> >> On 27 February 2018 at 03:51, Michal Simek wrote: >>> Hi Liam, >>> >>> On 27.2.2018 05:17, Liam Beguin wrote: Add basic tests for the

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

On 1.3.2018 05:01, Liam Beguin wrote: > Hi Michal, > > On 27 February 2018 at 03:51, Michal Simek wrote: >> Hi Liam, >> >> On 27.2.2018 05:17, Liam Beguin wrote: >>> Add basic tests for the spi_flash subsystem. >> >> Good to see this patch. >> FYI: We have created qspi

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

Hi Michal, On 27 February 2018 at 03:51, Michal Simek wrote: > Hi Liam, > > On 27.2.2018 05:17, Liam Beguin wrote: >> Add basic tests for the spi_flash subsystem. > > Good to see this patch. > FYI: We have created qspi tests too but didn't push it out because of >

[U-Boot] [PATCH 3/3] test/py: add spi_flash tests

Add basic tests for the spi_flash subsystem. Signed-off-by: Liam Beguin --- test/py/tests/test_sf.py | 233 +++ 1 file changed, 233 insertions(+) diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_sf.py new file mode 100644

Re: [U-Boot] [PATCH 3/3] test/py: add spi_flash tests

Hi Liam, On 27.2.2018 05:17, Liam Beguin wrote: > Add basic tests for the spi_flash subsystem. Good to see this patch. FYI: We have created qspi tests too but didn't push it out because of missing sf_configs options as you have below. We are testing the whole flash all the time. Test was