Re: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-26 Thread Minkyu Kang
Dear Tom 2009/9/23 Tom tom@windriver.com: Minkyu Kang wrote: This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com Add a better commit log. Explain why a special serial driver is needed instead of using the generic serial driver. ok. ---

Re: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-23 Thread Minkyu Kang
Dear Tom 2009/9/22 Tom tom@windriver.com: Minkyu Kang wrote: This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com Nak. This looks like the zoom2 serial driver. In the case of zoom2, special handling is needed because the serial is

Re: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-23 Thread Tom
Minkyu Kang wrote: Dear Tom 2009/9/22 Tom tom@windriver.com: Minkyu Kang wrote: This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com Nak. This looks like the zoom2 serial driver. In the case of zoom2, special handling is needed because

Re: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-23 Thread Tom
Minkyu Kang wrote: This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com Add a better commit log. Explain why a special serial driver is needed instead of using the generic serial driver. --- Changes since v1: - use serial multi API - use

[U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-22 Thread Minkyu Kang
This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com --- Changes since v1: - use serial multi API - use writel/readl function - remove duplicate code Changes since v2: - use sizeof() instead of the constant common/serial.c | 18 +++

Re: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver

2009-09-22 Thread Tom
Minkyu Kang wrote: This patch includes the serial driver for s5pc1xx Signed-off-by: Minkyu Kang mk7.k...@samsung.com Nak. This looks like the zoom2 serial driver. In the case of zoom2, special handling is needed because the serial is supplied by a detachable debug board and a runtime check