Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Wolfgang Denk
Dear Kumar Gala, In message you wrote: > > >>> +LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds > >>> +endif > >>> +endif > >>> +endif > >> > >> Why is this config.mk needed? Can you not do all this in the board > >> config file instead? > > Do you mean the board header file or arch/powerpc/co

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Wolfgang Denk
Dear Haiying Wang, In message <1296509955.2049.543.camel@haiying-laptop> you wrote: > > > Why is this config.mk needed? Can you not do all this in the board > > config file instead? > Do you mean the board header file or arch/powerpc/config.mk? I did not see > any LDSCRIPT defined in Freescale b

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Kumar Gala
On Jan 31, 2011, at 3:39 PM, Haiying Wang wrote: > On Mon, 2011-01-31 at 21:03 +0100, Wolfgang Denk wrote: >> Dear haiying.w...@freescale.com, >>> diff --git a/board/freescale/p1021mds/config.mk >>> b/board/freescale/p1021mds/config.mk >>> new file mode 100644 >>> index 000..3888f61 >>> ---

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Kumar Gala
> It seems there are a number of functions here which ar actually shared > with other files, for example board/freescale/p1022ds/ddr.c. > > I wonder if it is not possible to use more common code here - especially > given the fact that we already have a nice collection of such files: > > boa

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Haiying Wang
On Mon, 2011-01-31 at 21:03 +0100, Wolfgang Denk wrote: > Dear haiying.w...@freescale.com, > > diff --git a/board/freescale/p1021mds/config.mk > > b/board/freescale/p1021mds/config.mk > > new file mode 100644 > > index 000..3888f61 > > --- /dev/null > > +++ b/board/freescale/p1021mds/config.mk

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Scott Wood
On Mon, 31 Jan 2011 21:18:35 +0100 Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20110131140801.33609...@udp111988uds.am.freescale.net> you wrote: > > > > > Please rather omit the setting instead of using fillers that are of no > > > practical value. > > > > Well, they do make it easi

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Wolfgang Denk
Dear Scott Wood, In message <20110131140801.33609...@udp111988uds.am.freescale.net> you wrote: > > > Please rather omit the setting instead of using fillers that are of no > > practical value. > > Well, they do make it easier for a user to quickly see what the names > are that U-Boot expects for

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Scott Wood
On Mon, 31 Jan 2011 21:03:17 +0100 Wolfgang Denk wrote: > > +/* > > + * Environment Configuration > > + */ > > +#define CONFIG_HOSTNAMEp1021mds > > +#define CONFIG_ROOTPATH/nfsroot > > +#define CONFIG_BOOTFILEyour.uImage > > Please rather omit the setting instead of using fillers tha

Re: [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Wolfgang Denk
Dear haiying.w...@freescale.com, In message <1296499317-26616-4-git-send-email-haiying.w...@freescale.com> you wrote: > From: Haiying Wang > > Support P1021MDS board to boot from NAND flash (No NOR flash on this > board). And because P1021 only has 256K L2 SRAM, which can not used for final > u

[U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

2011-01-31 Thread Haiying.Wang
From: Haiying Wang Support P1021MDS board to boot from NAND flash (No NOR flash on this board). And because P1021 only has 256K L2 SRAM, which can not used for final uboot image, this patch also enables the TPL BOOT on P1021MDS so that DDR can be initialized in L2 SRAM through SPD code. So there