Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-14 Thread Marek Vasut
...@gmail.com] Sent: Monday, October 04, 2010 8:34 AM To: Kyungmin Park Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL Dne Ne 3. října 2010 16:27:04 Marek Vasut napsal(a): Dne Ne 3. října 2010 08:40:19 Kyungmin Park napsal(a): Hi

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-04 Thread Wolfgang Denk
Dear Marek Vasut, In message 201010040224.35419.marek.va...@gmail.com you wrote: The data section isn't writable, right ? The data section is (officially) writable only after relocation. This rule has the situation in mind that U-Boot starts runnng from some form of ROM (like NOR flash). If

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-04 Thread Scott Wood
On Sat, 2 Oct 2010 19:33:59 +0200 Marek Vasut marek.va...@gmail.com wrote: There apparantly is no reason for having onenand_read_page abstracted. Besides, it's static data which causes trouble. Why does static data cause trouble? I don't think purging the code of all instances of static data

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-03 Thread Kyungmin Park
Hi, No it's used another place. that's reason not static function pointer. I'll update it soon. Thank you, Kyungmin Park On Sun, Oct 3, 2010 at 2:33 AM, Marek Vasut marek.va...@gmail.com wrote: There apparantly is no reason for having onenand_read_page abstracted. Besides, it's static data

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-03 Thread Marek Vasut
Dne Ne 3. října 2010 08:40:19 Kyungmin Park napsal(a): Hi, No it's used another place. that's reason not static function pointer. I'll update it soon. Hey, my problem is this code hangs my CPU. If I apply this patch, it doesn't happen anymore. Where is this used and what's your proposed

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-03 Thread Marek Vasut
Dne Ne 3. října 2010 16:27:04 Marek Vasut napsal(a): Dne Ne 3. října 2010 08:40:19 Kyungmin Park napsal(a): Hi, No it's used another place. that's reason not static function pointer. I'll update it soon. Hey, my problem is this code hangs my CPU. If I apply this patch, it doesn't

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-03 Thread Kyungmin Park
Subject: Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL Dne Ne 3. října 2010 16:27:04 Marek Vasut napsal(a): Dne Ne 3. října 2010 08:40:19 Kyungmin Park napsal(a): Hi, No it's used another place. that's reason not static function pointer. I'll update it soon. Hey

Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-03 Thread Marek Vasut
! Thank you, Kyungmin Park -Original Message- From: Marek Vasut [mailto:marek.va...@gmail.com] Sent: Monday, October 04, 2010 8:34 AM To: Kyungmin Park Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL Dne Ne 3. října 2010 16

[U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL

2010-10-02 Thread Marek Vasut
There apparantly is no reason for having onenand_read_page abstracted. Besides, it's static data which causes trouble. Signed-off-by: Marek Vasut marek.va...@gmail.com --- onenand_ipl/onenand_read.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git