Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Bin Meng
Hi Jagan, On Wed, Oct 29, 2014 at 2:16 PM, Jagan Teki wrote: > Hi Bin, > > This looks odd to me - supporting array slow without support on fast read. > Please check the datasheets, and as per as my knowledge/experience it > should support both. It is not the flash but the controller only support

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Jagan Teki
Hi Bin, On 28 October 2014 16:09, Bin Meng wrote: > Hi Jagan, > > Thanks for the detailed explanation. > > On Tue, Oct 28, 2014 at 6:19 PM, Jagan Teki wrote: >> Hi Bin, >> >> Your understanding is quite normal - like the way of adding supported read >> command support, but here the sf logic to p

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Bin Meng
Hi Jagan, Thanks for the detailed explanation. On Tue, Oct 28, 2014 at 6:19 PM, Jagan Teki wrote: > Hi Bin, > > Your understanding is quite normal - like the way of adding supported read > command support, but here the sf logic to pick the read command is different. > > Please see below. > > On

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Jagan Teki
Hi Bin, Your understanding is quite normal - like the way of adding supported read command support, but here the sf logic to pick the read command is different. Please see below. On 28 October 2014 14:08, Bin Meng wrote: > Hi Jagan, > > On Tue, Oct 28, 2014 at 3:09 PM, Jagan Teki wrote: >> Hi

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Bin Meng
Hi Jagan, On Tue, Oct 28, 2014 at 3:09 PM, Jagan Teki wrote: > Hi Bin, > > On 28 October 2014 06:52, Bin Meng wrote: >> Hi Jegan, >> >> On Tue, Oct 28, 2014 at 2:08 AM, Jagan Teki wrote: >>> What is this, by defining RD_EXTN the fastest read cmd will pick based >>> on controller mode_rx >>> Why

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-28 Thread Jagan Teki
Hi Bin, On 28 October 2014 06:52, Bin Meng wrote: > Hi Jegan, > > On Tue, Oct 28, 2014 at 2:08 AM, Jagan Teki wrote: >> What is this, by defining RD_EXTN the fastest read cmd will pick based >> on controller mode_rx >> Why this RD_SLOW again? does this means the specific flash part will >> only

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-27 Thread Bin Meng
Hi Jegan, On Tue, Oct 28, 2014 at 2:08 AM, Jagan Teki wrote: > What is this, by defining RD_EXTN the fastest read cmd will pick based > on controller mode_rx > Why this RD_SLOW again? does this means the specific flash part will > only support slow read? Correct, the SST25* (except SST25VF064C)

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-27 Thread Jagan Teki
On 23 October 2014 19:07, Bin Meng wrote: > Explicitly list supported read commands in the flash prarmas table > for SST25* flash parts. > > Signed-off-by: Bin Meng > --- > drivers/mtd/spi/sf_params.c | 20 ++-- > include/spi_flash.h | 3 ++- > 2 files changed, 12 insert

Re: [U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-26 Thread Simon Glass
On 23 October 2014 07:37, Bin Meng wrote: > Explicitly list supported read commands in the flash prarmas table > for SST25* flash parts. > > Signed-off-by: Bin Meng > --- > drivers/mtd/spi/sf_params.c | 20 ++-- > include/spi_flash.h | 3 ++- > 2 files changed, 12 insert

[U-Boot] [PATCH 4/5] sf: Update SST25* flash params of supported read commands

2014-10-23 Thread Bin Meng
Explicitly list supported read commands in the flash prarmas table for SST25* flash parts. Signed-off-by: Bin Meng --- drivers/mtd/spi/sf_params.c | 20 ++-- include/spi_flash.h | 3 ++- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/mtd/spi/sf_