Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-19 Thread Mike Frysinger
On Tuesday 03 July 2012 20:13:37 Marek Vasut wrote: Dear Tom Rini, On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy Moly ... can we not

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-04 Thread Lukasz Majewski
Hi Marek, Dear Tom Rini, On Tue, Jul 03, 2012 at 11:29:31PM +0200, Marek Vasut wrote: Dear Lukasz Majewski, Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-04 Thread Marek Vasut
Dear Lukasz Majewski, [...] Holy Moly ... can we not make this into simple calls to those subsystems ? Instead invoking command is crazy ;-) Are they really simple? There's a few other places we do this, and so long as it's documented that DFU depends on CONFIG_FAT_WRITE for

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-04 Thread Lukasz Majewski
Hi Marek, Dear Lukasz Majewski, [...] Holy Moly ... can we not make this into simple calls to those subsystems ? Instead invoking command is crazy ;-) Are they really simple? There's a few other places we do this, and so long as it's documented that DFU depends on

[U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Lukasz Majewski
Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Vasut ma...@denx.de --- drivers/dfu/Makefile |1 + drivers/dfu/dfu_mmc.c | 126

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Marek Vasut
Dear Lukasz Majewski, Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Vasut ma...@denx.de --- [...] + +#include common.h +#include malloc.h +#include

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Tom Rini
On Tue, Jul 03, 2012 at 11:29:31PM +0200, Marek Vasut wrote: Dear Lukasz Majewski, Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Vasut ma...@denx.de

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Marek Vasut
Dear Tom Rini, On Tue, Jul 03, 2012 at 11:29:31PM +0200, Marek Vasut wrote: Dear Lukasz Majewski, Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc:

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Tom Rini
On Wed, Jul 04, 2012 at 12:01:27AM +0200, Marek Vasut wrote: Dear Tom Rini, On Tue, Jul 03, 2012 at 11:29:31PM +0200, Marek Vasut wrote: Dear Lukasz Majewski, Support for MMC storage devices to work with DFU framework. Signed-off-by: Lukasz Majewski l.majew...@samsung.com

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Marek Vasut
Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy Moly ... can we not make this into simple calls to those subsystems ? Instead invoking command is crazy ;-) Are they really simple? There's a few other

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Tom Rini
On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy Moly ... can we not make this into simple calls to those subsystems ? Instead invoking command

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Stephen Warren
On 07/03/2012 04:33 PM, Tom Rini wrote: On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy Moly ... can we not make this into simple calls to those subsystems ?

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Tom Rini
On Tue, Jul 03, 2012 at 05:07:04PM -0600, Stephen Warren wrote: On 07/03/2012 04:33 PM, Tom Rini wrote: On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Stephen Warren
On 07/03/2012 05:38 PM, Tom Rini wrote: On Tue, Jul 03, 2012 at 05:07:04PM -0600, Stephen Warren wrote: On 07/03/2012 04:33 PM, Tom Rini wrote: On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); +

Re: [U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

2012-07-03 Thread Marek Vasut
Dear Tom Rini, On Wed, Jul 04, 2012 at 12:31:14AM +0200, Marek Vasut wrote: Dear Tom Rini, [...] + debug(%s: %s 0x%p\n, __func__, cmd_buf, cmd_buf); + run_command(cmd_buf, 0); Holy Moly ... can we not make this into simple calls to those subsystems ?