Re: [U-Boot] [PATCH 4/8 v2] powerpc/85xx: add TPL_BOOT support

2011-01-24 Thread Wolfgang Denk
Dear Haiying Wang, In message <1295840749.2196.3.camel@haiying-laptop> you wrote: > > > > +#ifdef CONFIG_FSL_CORENET > > > + return (gd->bus_clk + 8) / 16; > > > +#else > > > + return (gd->bus_clk + 4UL)/8UL; > > > +#endif > > > > This looks inconsistent. Either this should be "... +8UL) / 16UL"

Re: [U-Boot] [PATCH 4/8 v2] powerpc/85xx: add TPL_BOOT support

2011-01-23 Thread Haiying Wang
On Sat, 2011-01-22 at 23:12 +0100, Wolfgang Denk wrote: > You should not undo a previous copyright. I guess you mean: > > Copyright 2009-2010 Freescale Semiconductor, Inc. > > ? Yes. Sorry about it. > > +DECLARE_GLOBAL_DATA_PTR; > > Please move this up to top of file. OK. > > +unsigned lon

Re: [U-Boot] [PATCH 4/8 v2] powerpc/85xx: add TPL_BOOT support

2011-01-22 Thread Wolfgang Denk
Dear haiying.w...@freescale.com, In message <1291218463-4211-1-git-send-email-haiying.w...@freescale.com> you wrote: > From: Haiying Wang > > Signed-off-by: Haiying Wang > --- > Splitted from TPL patch to only address 85xx changes > arch/powerpc/cpu/mpc85xx/cpu_init_nand.c | 34 ++-

Re: [U-Boot] [PATCH 4/8 v2] powerpc/85xx: add TPL_BOOT support

2011-01-21 Thread Kumar Gala
On Dec 1, 2010, at 9:47 AM, wrote: > From: Haiying Wang > > Signed-off-by: Haiying Wang > --- > Splitted from TPL patch to only address 85xx changes > arch/powerpc/cpu/mpc85xx/cpu_init_nand.c | 34 ++- > arch/powerpc/cpu/mpc85xx/start.S | 12 ++-- > arch/powerpc/cpu/mpc85x

[U-Boot] [PATCH 4/8 v2] powerpc/85xx: add TPL_BOOT support

2010-12-01 Thread Haiying.Wang
From: Haiying Wang Signed-off-by: Haiying Wang --- Splitted from TPL patch to only address 85xx changes arch/powerpc/cpu/mpc85xx/cpu_init_nand.c | 34 ++- arch/powerpc/cpu/mpc85xx/start.S | 12 ++-- arch/powerpc/cpu/mpc85xx/u-boot-tpl.lds | 99