Re: [U-Boot] [PATCH 43/50] rockchip: pinctrl: Reduce the size for SPL

2016-01-19 Thread Simon Glass
Hi, On 18 January 2016 at 02:39, Sjoerd Simons wrote: > On Thu, 2016-01-14 at 08:51 -0700, Simon Glass wrote: >> Hi Eddie, >> >> On 14 January 2016 at 05:47, Eddie Cai >> wrote: >> > Hi Simon >> > >> > I think the best way to reduce SPL size is to jump back to boot >> > rom. >> > Which don't req

Re: [U-Boot] [PATCH 43/50] rockchip: pinctrl: Reduce the size for SPL

2016-01-18 Thread Sjoerd Simons
On Thu, 2016-01-14 at 08:51 -0700, Simon Glass wrote: > Hi Eddie, > > On 14 January 2016 at 05:47, Eddie Cai > wrote: > > Hi Simon > > > > I think the best way to reduce SPL size is to jump back to boot > > rom. > > Which don't require eMMC, SD card driver in SPL any more. Even > > clock > > and

Re: [U-Boot] [PATCH 43/50] rockchip: pinctrl: Reduce the size for SPL

2016-01-14 Thread Simon Glass
Hi Eddie, On 14 January 2016 at 05:47, Eddie Cai wrote: > Hi Simon > > I think the best way to reduce SPL size is to jump back to boot rom. > Which don't require eMMC, SD card driver in SPL any more. Even clock > and pinctrl driver is not required. All we need is DDR initialization. > We should d

Re: [U-Boot] [PATCH 43/50] rockchip: pinctrl: Reduce the size for SPL

2016-01-14 Thread Eddie Cai
Hi Simon I think the best way to reduce SPL size is to jump back to boot rom. Which don't require eMMC, SD card driver in SPL any more. Even clock and pinctrl driver is not required. All we need is DDR initialization. We should do as little thing as possible in SPL and let U-boot take care others.

[U-Boot] [PATCH 43/50] rockchip: pinctrl: Reduce the size for SPL

2016-01-13 Thread Simon Glass
This file has many features that are not needed by SPL. Use #ifdef to remove the unused features and reduce the code size. Signed-off-by: Simon Glass --- drivers/pinctrl/rockchip/pinctrl_rk3288.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/p