Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-13 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <1012612599.2335651.1344807326593.javamail.r...@advansee.com> you wrote: > > > Please feel free to add this to your local code. > > By "local", do you mean that this new suggestion would still not be generic > enough for you to be interest

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Mike Frysinger
On Sunday 12 August 2012 13:11:03 Benoît Thébaudeau wrote: > OK. Actually, the only reason for which I need this patch is to make a > variable read-only, and the only reason for which you reject it is because > you fear that it breaks something. and because it bloats the codebase for 0 gain for th

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Benoît Thébaudeau
Dear Wolfgang Denk, > > OK. Actually, the only reason for which I need this patch is to > > make a variable > > read-only, and the only reason for which you reject it is because > > you fear that > > it breaks something. > > > > So we could add a config like CONFIG_BOARD_REV_RO_VARIABLE to > > ena

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Jeroen Hofstee
On 08/12/2012 11:06 PM, Wolfgang Denk wrote: Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <1323086777.2324156.1344780597072.javamail.r...@advansee.com> you wrote: Anyway, when you will have implemented read-only and volatile flags for env vars, this patch will no longer be needed.

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <383502175.2331918.1344791463023.javamail.r...@advansee.com> you wrote: > > OK. Actually, the only reason for which I need this patch is to make a > variable > read-only, and the only reason for which you reject it is because you fear >

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <1323086777.2324156.1344780597072.javamail.r...@advansee.com> you wrote: > > Anyway, when you will have implemented read-only and volatile flags for env > vars, this patch will no longer be needed. But with the current code, there is > no

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <1642597694.2324115.1344780168514.javamail.r...@advansee.com> you wrote: > > > You cannot expect to see the real, production environments in the > > mainline source tree. > > Right, but the same applied to serial# and ethaddr when they wer

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Benoît Thébaudeau
Dear Mike Frysinger, > > > > I have searched such a usage in the tree, but did not find any, > > > > so > > > > this should > > > > not break anything. > > > > > > You cannot expect to see the real, production environments in the > > > mainline source tree. > > > > Right, but the same applied to

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Mike Frysinger
On Sunday 12 August 2012 10:02:48 Benoît Thébaudeau wrote: > Dear Wolfgang Denk, > > > I have searched such a usage in the tree, but did not find any, so > > > this should > > > not break anything. > > > > You cannot expect to see the real, production environments in the > > mainline source tree.

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Benoît Thébaudeau
Dear Wolfgang Denk, > > > I have searched such a usage in the tree, but did not find any, > > > so > > > this should > > > not break anything. > > > > You cannot expect to see the real, production environments in the > > mainline source tree. > > Right, but the same applied to serial# and ethadd

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Benoît Thébaudeau
Dear Wolfgang Denk, > > I have searched such a usage in the tree, but did not find any, so > > this should > > not break anything. > > You cannot expect to see the real, production environments in the > mainline source tree. Right, but the same applied to serial# and ethaddr when they were added

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <1666183421.2304101.1344712292461.javamail.r...@advansee.com> you wrote: > > I have searched such a usage in the tree, but did not find any, so this should > not break anything. You cannot expect to see the real, production environments i

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-12 Thread Wolfgang Denk
Dear =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?=, In message <2028294275.2280404.1344620768178.javamail.r...@advansee.com> you wrote: > The board revision can be a useful env var, like its serial number. It can be useful, but it appears not many boards needed it so far, so I suggest we leave as is;

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-11 Thread Benoît Thébaudeau
Hi Mike, On Saturday 11 August 2012 19:48:33 Mike Frysinger wrote: > On Friday 10 August 2012 13:46:08 Benoît Thébaudeau wrote: > > The board revision can be a useful env var, like its serial number. > > unless i missed something, there is no standard "rev" variable today, > which > means this ch

Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-11 Thread Mike Frysinger
On Friday 10 August 2012 13:46:08 Benoît Thébaudeau wrote: > The board revision can be a useful env var, like its serial number. unless i missed something, there is no standard "rev" variable today, which means this change can easily break anyone who happens to already be using a variable named

[U-Boot] [PATCH 5/5] Add env var giving the board revision

2012-08-10 Thread Benoît Thébaudeau
The board revision can be a useful env var, like its serial number. Signed-off-by: Benoît Thébaudeau Cc: Wolfgang Denk --- {u-boot-4d3c95f.orig => u-boot-4d3c95f}/README | 21 ++-- .../common/cmd_nvedit.c|5 +++-- .../tools/env/fw_env.c