Re: [U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2011-01-18 Thread Wolfgang Denk
Dear Aneesh V, In message <4d3525cd.8090...@ti.com> you wrote: > > +struct __attribute__ ((__packed__)) emu_hal_params { > +u32 num_params; > +u32 param1; > +}; > >>> > >>> Why exactly do we need the "__attribute__ ((__packed__))" here? > >> > >> Because a poin

Re: [U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2011-01-17 Thread Aneesh V
Dear Wolfgang, On Tuesday 18 January 2011 03:25 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4d2b1a90.9030...@ti.com> you wrote: >> +struct __attribute__ ((__packed__)) emu_hal_params { + u32 num_params; + u32 param1; +}; >>> >>> Why exactly do we need the "__att

Re: [U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2011-01-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4d2b1a90.9030...@ti.com> you wrote: > > >> +struct __attribute__ ((__packed__)) emu_hal_params { > >> + u32 num_params; > >> + u32 param1; > >> +}; > > > > Why exactly do we need the "__attribute__ ((__packed__))" here? > > Because a pointer to it has to be passed to

Re: [U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2011-01-10 Thread Aneesh V
Dear Wolfgang, On Monday 10 January 2011 04:27 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1293018898-13253-8-git-send-email-ane...@ti.com> you wrote: >> adapt omap3 to the new layered cache maintenance framework > ... > >> +/* Declarations */ > > Please drop this comment. Everybody

Re: [U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2011-01-09 Thread Wolfgang Denk
Dear Aneesh V, In message <1293018898-13253-8-git-send-email-ane...@ti.com> you wrote: > adapt omap3 to the new layered cache maintenance framework ... > +/* Declarations */ Please drop this comment. Everybody sees what this is. > +#ifndef CONFIG_L2_OFF > /* > - * Writing to AuxCR i

[U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

2010-12-22 Thread Aneesh V
adapt omap3 to the new layered cache maintenance framework Signed-off-by: Aneesh V --- arch/arm/cpu/armv7/omap3/Makefile |1 - arch/arm/cpu/armv7/omap3/board.c| 151 ++-- arch/arm/cpu/armv7/omap3/cache.S| 263 --- arch/a