Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-14 Thread Mateusz Zalega
On 01/14/14 01:49, Minkyu Kang wrote: On 09/01/14 23:31, Mateusz Zalega wrote: In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc:

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-13 Thread Lukasz Majewski
Hi Mateusz, In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Minkyu Kang

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-13 Thread Mateusz Zalega
On 01/10/14 06:08, Jaehoon Chung wrote: index dc155ad..0d8f30d 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -37,6 +37,9 @@ static struct ums ums_dev = { static struct ums *ums_disk_init(struct mmc *mmc) { +if (mmc_init(mmc)) +return NULL;

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-13 Thread Michael Trimarchi
Hi On Mon, Jan 13, 2014 at 3:39 PM, Mateusz Zalega m.zal...@samsung.com wrote: On 01/10/14 06:08, Jaehoon Chung wrote: index dc155ad..0d8f30d 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -37,6 +37,9 @@ static struct ums ums_dev = { static struct ums

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-13 Thread Mateusz Zalega
On 01/13/14 15:43, Michael Trimarchi wrote: On Mon, Jan 13, 2014 at 3:39 PM, Mateusz Zalega m.zal...@samsung.com wrote: On 01/10/14 06:08, Jaehoon Chung wrote: index dc155ad..0d8f30d 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -37,6 +37,9 @@ static struct ums

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-13 Thread Minkyu Kang
On 09/01/14 23:31, Mateusz Zalega wrote: In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com

[U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-09 Thread Mateusz Zalega
In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Kyungmin

Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

2014-01-09 Thread Jaehoon Chung
Hi Mateusz, On 01/09/2014 11:31 PM, Mateusz Zalega wrote: In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski