Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Wolfgang Denk
Dear Tom, In message <5331bc48.7020...@wwwdotorg.org> Stephen Warren wrote: > On 03/21/2014 12:28 PM, Stephen Warren wrote: > > From: Stephen Warren > > > > This removes a bunch of open-coded register IO, masking, and shifting. > > I would have squashed this into "ARM: tegra: pinctrl: remove dup

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Stephen Warren
On 03/21/2014 12:28 PM, Stephen Warren wrote: > From: Stephen Warren > > This removes a bunch of open-coded register IO, masking, and shifting. > I would have squashed this into "ARM: tegra: pinctrl: remove duplication" > except that keeping it a separate commit allows easier bisection of any > i

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Wolfgang Denk
Dear Stephen Warren, In message <5331b4e4.5090...@wwwdotorg.org> you wrote: > > > Please do not invent new bit manipulation functions. Just use the > > standard I/O accessors. And whenever possible, please remove pre- > > existing functions. > > > > I've just recently sent patches to get rid of

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Stephen Warren
On 03/25/2014 10:51 AM, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message <5331a6b6.8090...@wwwdotorg.org> you wrote: >> >>> Or perhaps update_reg_mask_shift_val()? >> >> Still, I can rename the function if you want; it certainly does make it >> obvious. It's rather a long name though, bu

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Wolfgang Denk
Dear Stephen Warren, In message <5331a6b6.8090...@wwwdotorg.org> you wrote: > > > Or perhaps update_reg_mask_shift_val()? > > Still, I can rename the function if you want; it certainly does make it > obvious. It's rather a long name though, but I guess wrapping the > parameters isn't too bad. Pl

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Stephen Warren
On 03/25/2014 10:04 AM, Simon Glass wrote: > On 25 March 2014 08:54, Stephen Warren wrote: >> On 03/24/2014 08:27 PM, Simon Glass wrote: >>> On 21 March 2014 11:28, Stephen Warren wrote: This removes a bunch of open-coded register IO, masking, and shifting. I would have squashed this in

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Simon Glass
Hi Stephen, On 25 March 2014 08:54, Stephen Warren wrote: > On 03/24/2014 08:27 PM, Simon Glass wrote: >> Hi Stephen, >> >> On 21 March 2014 11:28, Stephen Warren wrote: >>> From: Stephen Warren >>> >>> This removes a bunch of open-coded register IO, masking, and shifting. >>> I would have squa

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-25 Thread Stephen Warren
On 03/24/2014 08:27 PM, Simon Glass wrote: > Hi Stephen, > > On 21 March 2014 11:28, Stephen Warren wrote: >> From: Stephen Warren >> >> This removes a bunch of open-coded register IO, masking, and shifting. >> I would have squashed this into "ARM: tegra: pinctrl: remove duplication" >> except t

Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-24 Thread Simon Glass
Hi Stephen, On 21 March 2014 11:28, Stephen Warren wrote: > From: Stephen Warren > > This removes a bunch of open-coded register IO, masking, and shifting. > I would have squashed this into "ARM: tegra: pinctrl: remove duplication" > except that keeping it a separate commit allows easier bisecti

[U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

2014-03-21 Thread Stephen Warren
From: Stephen Warren This removes a bunch of open-coded register IO, masking, and shifting. I would have squashed this into "ARM: tegra: pinctrl: remove duplication" except that keeping it a separate commit allows easier bisection of any issues that are introduced by this patch. I also wrote this