Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-23 Thread Stefano Babic
On 20/04/2012 10:54, Timo Ketola wrote: as far as I can see, there are some inconsistencies. All boards define CONFIG_MII, but they really need CONFIG_RMII, because only with my last patch I set the gasket for MII. The driver has always set in a fixed way the gasket for RMII, independently if

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-23 Thread Timo Ketola
On 23.04.2012 10:55, Stefano Babic wrote: Instead of using CONFIG_MII or CONFIG_RMII, we can make use of CONFIG_FEC_XCV_TYPE, as it was already introduced, but making it consistent for all boards. Second for that. -- Timo ___ U-Boot mailing list

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-20 Thread Stefano Babic
On 20/04/2012 06:35, Timo Ketola wrote: [undeleted Stefano from CC-list] Hi Timo, hi Troy, On 20.04.2012 00:23, Troy Kisky wrote: On 4/19/2012 2:13 PM, Troy Kisky wrote: On 4/19/2012 1:18 PM, Timo Ketola wrote: On 19.04.2012 22:27, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-20 Thread Timo Ketola
Dear Stefano, Troy, Scott, On 20.04.2012 10:30, Stefano Babic wrote: On 20/04/2012 06:35, Timo Ketola wrote: [undeleted Stefano from CC-list] Hi Timo, hi Troy, On 20.04.2012 00:23, Troy Kisky wrote: On 4/19/2012 2:13 PM, Troy Kisky wrote: On 4/19/2012 1:18 PM, Timo Ketola wrote: On

[U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Timo Ketola
Gasket needs a different configuration for 10BaseT than for higher speeds. Signed-off-by: Timo Ketola t...@exertus.fi --- Changes in v4: - Rewrapped commit message Changes in v2: - Dropped patches 2 and 3 so this one changed from 5 to 3 - Rebased to u-boot-imx next - Removed the remove of

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Stefano Babic
On 19/04/2012 10:55, Timo Ketola wrote: Gasket needs a different configuration for 10BaseT than for higher speeds. Signed-off-by: Timo Ketola t...@exertus.fi --- Acked-by: Stefano Babic sba...@denx.de Best regards, Stefano Babic --

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Troy Kisky
On 4/19/2012 1:55 AM, Timo Ketola wrote: Gasket needs a different configuration for 10BaseT than for higher speeds. Signed-off-by: Timo Ketolat...@exertus.fi --- Changes in v4: - Rewrapped commit message Changes in v2: - Dropped patches 2 and 3 so this one changed from 5 to 3 - Rebased to

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Timo Ketola
On 19.04.2012 22:27, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola wrote: -#if !defined(CONFIG_MII) - /* configure gasket for RMII, 50 MHz, no loopback, and no echo */ - writew(MIIGSK_CFGR_IF_MODE_RMII,fec-eth-miigsk_cfgr); +#if defined(CONFIG_RMII) While this change seems to make

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Troy Kisky
On 4/19/2012 1:18 PM, Timo Ketola wrote: On 19.04.2012 22:27, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola wrote: -#if !defined(CONFIG_MII) - /* configure gasket for RMII, 50 MHz, no loopback, and no echo */ - writew(MIIGSK_CFGR_IF_MODE_RMII,fec-eth-miigsk_cfgr); +#if

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Troy Kisky
On 4/19/2012 2:13 PM, Troy Kisky wrote: On 4/19/2012 1:18 PM, Timo Ketola wrote: On 19.04.2012 22:27, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola wrote: -#if !defined(CONFIG_MII) - /* configure gasket for RMII, 50 MHz, no loopback, and no echo */ -

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Troy Kisky
On 4/19/2012 1:55 AM, Timo Ketola wrote: Gasket needs a different configuration for 10BaseT than for higher speeds. Signed-off-by: Timo Ketolat...@exertus.fi --- Changes in v4: - Rewrapped commit message Changes in v2: - Dropped patches 2 and 3 so this one changed from 5 to 3 - Rebased to

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Timo Ketola
[undeleted Stefano from CC-list] On 20.04.2012 00:28, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola wrote: ... + if (speed != _10BASET) ... Can you fix 10BASET for non-reduced pin count boards as well? Are they broken? How? If they are, I'm afraid I don't have a board to test. --

Re: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket

2012-04-19 Thread Timo Ketola
[undeleted Stefano from CC-list] On 20.04.2012 00:23, Troy Kisky wrote: On 4/19/2012 2:13 PM, Troy Kisky wrote: On 4/19/2012 1:18 PM, Timo Ketola wrote: On 19.04.2012 22:27, Troy Kisky wrote: On 4/19/2012 1:55 AM, Timo Ketola wrote: -#if !defined(CONFIG_MII) - /* configure gasket for RMII,