Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-22 Thread Felipe Balbi
Hi, Lukasz Majewski writes: [snip] >> > I do appreciate that you tested it - even better, that with >> > different approach. >> > >> > However, some time ago Stephen Warren has rewritten tests for DFU, >> > UMS to use some python infrastructure. Those tests (especially DFU, >>

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Felipe Balbi
Hi, Lukasz Majewski writes: >> Lukasz Majewski writes: >> >> > >> drivers/usb/gadget/f_dfu.c | 2 +- >> >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> >> > >> diff --git a/drivers/usb/gadget/f_dfu.c >> >> > >>

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Felipe Balbi
Hi, Lukasz Majewski writes: >> Lukasz Majewski writes: >> >> Lukasz Majewski writes: >> >> >> > >> drivers/usb/gadget/f_dfu.c | 2 +- >> >> >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> > >> >> >> >> > >> diff --git

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Lukasz Majewski
Hi Felipe, > > Hi, > > Lukasz Majewski writes: > >> Lukasz Majewski writes: > >> >> Lukasz Majewski writes: > >> >> >> > >> drivers/usb/gadget/f_dfu.c | 2 +- > >> >> >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> >> > >> > >>

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Lukasz Majewski
Hi. > > Hi, > > Lukasz Majewski writes: > >> Lukasz Majewski writes: > >> >> > >> drivers/usb/gadget/f_dfu.c | 2 +- > >> >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > >> > >> >> > >> diff --git a/drivers/usb/gadget/f_dfu.c > >> >> > >>

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Lukasz Majewski
Hi Felipe, > > Hi Lukasz, > > Lukasz Majewski writes: > >> > >> drivers/usb/gadget/f_dfu.c | 2 +- > >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> > >> > >> diff --git a/drivers/usb/gadget/f_dfu.c > >> > >> b/drivers/usb/gadget/f_dfu.c index

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-21 Thread Felipe Balbi
Hi Lukasz, Lukasz Majewski writes: >> > >> drivers/usb/gadget/f_dfu.c | 2 +- >> > >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> >> > >> diff --git a/drivers/usb/gadget/f_dfu.c >> > >> b/drivers/usb/gadget/f_dfu.c index 8e7c981657..64cdfa7c98 >> > >> 100644 ---

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-13 Thread Andy Shevchenko
On Mon, 2017-02-13 at 14:41 +0100, Lukasz Majewski wrote: > > [1] https://github.com/andy-shev/u-boot/tree/edison > > [2] https://communities.intel.com/message/435516#435516 > > > > Ok. I will check this. Thanks for pointing out :-) Just in case, mentioned branch is occasionally rebased, so,

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-13 Thread Lukasz Majewski
Hi Felipe, > > Hi Lukasz, > > Lukasz Majewski writes: > > Hi Felipe, > > > > Thanks for the patch. > > Please see my comments below. > > > > On 13 Feb 2017 11:42 am, Felipe Balbi > > wrote: > > > > Hi, > > > > Marek Vasut writes:

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-13 Thread Felipe Balbi
Hi Lukasz, Lukasz Majewski writes: > Hi Felipe, > > Thanks for the patch. > Please see my comments below. > > On 13 Feb 2017 11:42 am, Felipe Balbi wrote: > > Hi, > > Marek Vasut writes: > > On 02/10/2017 05:32 PM, Andy

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-13 Thread Felipe Balbi
Hi, Marek Vasut writes: > On 02/10/2017 05:32 PM, Andy Shevchenko wrote: >> From: Felipe Balbi >> >> If last packet is short, we shouldn't write req->length bytes to >> non-volatile media, we should write only what's available to us, which >> is

Re: [U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-10 Thread Marek Vasut
On 02/10/2017 05:32 PM, Andy Shevchenko wrote: > From: Felipe Balbi > > If last packet is short, we shouldn't write req->length bytes to > non-volatile media, we should write only what's available to us, which > is held in req->actual. > > Signed-off-by: Felipe

[U-Boot] [PATCH v1] usb: gadget: f_dfu: write req->actual bytes

2017-02-10 Thread Andy Shevchenko
From: Felipe Balbi If last packet is short, we shouldn't write req->length bytes to non-volatile media, we should write only what's available to us, which is held in req->actual. Signed-off-by: Felipe Balbi Signed-off-by: Andy