Re: [U-Boot] [PATCH v1 3/4] dfu: Add optional timeout parameter

2019-11-27 Thread Lukasz Majewski
Hi Andy, > On Wed, Nov 27, 2019 at 11:56:15AM +0100, Lukasz Majewski wrote: > > > Thank you for your work on enhancing DFU. The patch series is > > generally Ok. > > > > Please find some minor comments/requests below. > > Thank you for review, my answers below. > > > > +#ifdef

Re: [U-Boot] [PATCH v1 3/4] dfu: Add optional timeout parameter

2019-11-27 Thread Andy Shevchenko
On Wed, Nov 27, 2019 at 11:56:15AM +0100, Lukasz Majewski wrote: > Thank you for your work on enhancing DFU. The patch series is generally > Ok. > > Please find some minor comments/requests below. Thank you for review, my answers below. > > +#ifdef CONFIG_DFU_TIMEOUT > > +

Re: [U-Boot] [PATCH v1 3/4] dfu: Add optional timeout parameter

2019-11-27 Thread Lukasz Majewski
Hi Andy, Thank you for your work on enhancing DFU. The patch series is generally Ok. Please find some minor comments/requests below. > When the `dfu` command is called from the U-Boot environment, > it now accepts an optional parameter that specifies a timeout (in > seconds). If a DFU

[U-Boot] [PATCH v1 3/4] dfu: Add optional timeout parameter

2019-11-13 Thread Andy Shevchenko
When the `dfu` command is called from the U-Boot environment, it now accepts an optional parameter that specifies a timeout (in seconds). If a DFU connection is not made within that time the `dfu` command exits (as it would if Ctrl+C was pressed). If the timeout is left empty or being zero the