Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Tom/Stefano, On Thu, Feb 15, 2018 at 12:44 PM, Tom Rini wrote: > On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: >> Hi Fabio, >> >> > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. >> > >> > Commit d695d6627803 ("spl: eMMC/SD: Provide one

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

On 02/15/2018 06:09 PM, Stefano Babic wrote: > Hi Lukasz, > > On 15/02/2018 15:58, Lukasz Majewski wrote: >> Hi Tom, >> >>> On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: Hi Fabio, > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > >

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Lukasz, On 15/02/2018 15:58, Lukasz Majewski wrote: > Hi Tom, > >> On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: >>> Hi Fabio, >>> This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak

[U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() function") breaks the boot on several i.MX6 boards, such as cuboxi and wandboard: U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33 +1300) Trying to

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Lukasz, On Thu, Feb 15, 2018 at 12:58 PM, Lukasz Majewski wrote: > As this patch showed - spotting some "implicit" errors - which cannot be > found with travis CI build tests consumes some time. Travis CI build test is great, but we also need boot tests to catch issues like

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Tom, > On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: > > Hi Fabio, > > > > > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > > > > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak > > > spl_boot_mode() function") breaks the boot on several i.MX6

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

On 02/15/2018 03:44 PM, Tom Rini wrote: > On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: >> Hi Fabio, >> >>> This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. >>> >>> Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() >>> function") breaks the boot

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: > Hi Fabio, > > > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() > > function") breaks the boot on several i.MX6 boards, > > such as

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Lukasz, On Thu, Feb 15, 2018 at 12:33 PM, Lukasz Majewski wrote: > 2. If you agree - I can prepare the code to put imx code there they > were before this patch (to override the __weak function). > In that way we would got the cleanup for other archs in. As we are in rc2 I

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Stefano, > Hi Heiko, > > On 15/02/2018 13:14, Fabio Estevam wrote: > > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak > > spl_boot_mode() function") breaks the boot on several i.MX6 boards, > > such as cuboxi and

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Fabio, > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() > function") breaks the boot on several i.MX6 boards, > such as cuboxi and wandboard: > > U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 -

Re: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function"

Hi Heiko, On 15/02/2018 13:14, Fabio Estevam wrote: > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() > function") breaks the boot on several i.MX6 boards, > such as cuboxi and wandboard: > > U-Boot SPL