Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-09 Thread Detlev Zundel
Hi Graeme, Hi Wolfgang On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message capnjgz15f_gva5+mm1em-l2smxt1waatxqikuhoqat893t9...@mail.gmail.com you wrote: This discussion was regarding the need to #ifdef the variable declaration, viz: #if

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-09 Thread Simon Glass
Hi Wolfgang, On Tue, Nov 8, 2011 at 2:49 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message capnjgz15f_gva5+mm1em-l2smxt1waatxqikuhoqat893t9...@mail.gmail.com you wrote: This discussion was regarding the need to #ifdef the variable declaration, viz: #if

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-09 Thread Simon Glass
Hi Detlev, On Wed, Nov 9, 2011 at 5:45 AM, Detlev Zundel d...@denx.de wrote: Hi Graeme, Hi Wolfgang On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message capnjgz15f_gva5+mm1em-l2smxt1waatxqikuhoqat893t9...@mail.gmail.com you wrote: This

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Detlev Zundel
Hi Mike, On Monday 31 October 2011 17:06:46 Simon Glass wrote: On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote: On Sunday 23 October 2011 23:44:35 Simon Glass wrote: --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c flash_size = flash_init(); if (flash_size

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Simon Glass
Hi Detlev, On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundel d...@denx.de wrote: Hi Mike, On Monday 31 October 2011 17:06:46 Simon Glass wrote: On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote: On Sunday 23 October 2011 23:44:35 Simon Glass wrote: --- a/arch/arm/lib/board.c +++

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Albert ARIBAUD
Le 08/11/2011 16:57, Simon Glass a écrit : Hi Detlev, On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundeld...@denx.de wrote: Hi Mike, On Monday 31 October 2011 17:06:46 Simon Glass wrote: On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote: On Sunday 23 October 2011 23:44:35 Simon Glass

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Simon Glass
Hi Albert, On Tue, Nov 8, 2011 at 11:46 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Le 08/11/2011 16:57, Simon Glass a écrit : Hi Detlev, On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundeld...@denx.de  wrote: Hi Mike, On Monday 31 October 2011 17:06:46 Simon Glass wrote: On Sun, Oct

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Wolfgang Denk
Dear Simon Glass, In message capnjgz15f_gva5+mm1em-l2smxt1waatxqikuhoqat893t9...@mail.gmail.com you wrote: This discussion was regarding the need to #ifdef the variable declaration, viz: #if defined(THING1) || defined(THING2) const char *cat; #endif ... #ifdef THING1 cat =

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-11-08 Thread Graeme Russ
Hi Wolfgang On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message capnjgz15f_gva5+mm1em-l2smxt1waatxqikuhoqat893t9...@mail.gmail.com you wrote: This discussion was regarding the need to #ifdef the variable declaration, viz: #if defined(THING1)

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-31 Thread Simon Glass
Hi Mike, On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger vap...@gentoo.org wrote: On Sunday 23 October 2011 23:44:35 Simon Glass wrote: --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c       flash_size = flash_init();       if (flash_size 0) {  # ifdef CONFIG_SYS_FLASH_CHECKSUM +    

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-31 Thread Mike Frysinger
On Monday 31 October 2011 17:06:46 Simon Glass wrote: On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote: On Sunday 23 October 2011 23:44:35 Simon Glass wrote: --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c flash_size = flash_init(); if (flash_size 0) { #

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-30 Thread Mike Frysinger
On Sunday 23 October 2011 23:44:35 Simon Glass wrote: --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c flash_size = flash_init(); if (flash_size 0) { # ifdef CONFIG_SYS_FLASH_CHECKSUM + char *s = getenv(flashchecksum); + print_size(flash_size,

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Albert ARIBAUD
Hi Wolfgang, Le 24/10/2011 21:13, Wolfgang Denk a écrit : Dear Simon Glass, In message1319427875-29965-1-git-send-email-...@chromium.org you wrote: Commit dc8bbea removed a local variable that is used in most ARM boards. Since we want to avoid an 'unused variable' warning with later

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message 4ea65cbf.7060...@aribaud.net you wrote: I've just fetched u-boot and I don't see this one. Can you push u-boot/master so that I can rebase u-boot-arm/master on it and launch some tests? Done. Best regards, Wolfgang Denk -- DENX Software Engineering

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Albert ARIBAUD
Le 25/10/2011 09:50, Wolfgang Denk a écrit : Dear Albert ARIBAUD, In message4ea65cbf.7060...@aribaud.net you wrote: I've just fetched u-boot and I don't see this one. Can you push u-boot/master so that I can rebase u-boot-arm/master on it and launch some tests? Done. Hmm... Weird. I've

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Simon Glass
Hi Albert, On Tue, Oct 25, 2011 at 11:21 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Le 25/10/2011 09:50, Wolfgang Denk a écrit : Dear Albert ARIBAUD, In message4ea65cbf.7060...@aribaud.net  you wrote: I've just fetched u-boot and I don't see this one. Can you push u-boot/master

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message 4ea6fe3b.9080...@aribaud.net you wrote: I've just fetched u-boot and I don't see this one. Can you push u-boot/master so that I can rebase u-boot-arm/master on it and launch some tests? Done. Hmm... Weird. I've just fetched u-Boot again, and I cannot

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-25 Thread Simon Glass
On Tue, Oct 25, 2011 at 12:36 PM, Wolfgang Denk w...@denx.de wrote: Dear Albert ARIBAUD, In message 4ea6fe3b.9080...@aribaud.net you wrote: I've just fetched u-boot and I don't see this one. Can you push u-boot/master so that I can rebase u-boot-arm/master on it and launch some tests?

Re: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-24 Thread Wolfgang Denk
Dear Simon Glass, In message 1319427875-29965-1-git-send-email-...@chromium.org you wrote: Commit dc8bbea removed a local variable that is used in most ARM boards. Since we want to avoid an 'unused variable' warning with later compilers, and the #ifdef logic of whether this variable is

[U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-23 Thread Simon Glass
Commit dc8bbea removed a local variable that is used in most ARM boards. Since we want to avoid an 'unused variable' warning with later compilers, and the #ifdef logic of whether this variable is required is bit painful, this declares the variable local to the block of code that needs it.