Re: [U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

2013-09-26 Thread Alexey Brodkin
On 09/26/2013 09:26 AM, Mischa Jonker wrote: Vipin wrote: I have also faced this problem before. May be a better solution is to place all the struct and buffer declarations at the very start of dw_eth_dev structure (off-course with a comment that these should not be moved). It may avoid the

[U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

2013-09-25 Thread Alexey Brodkin
It's important that buffer descriptors are aligned in accordance to GMAC data bus width (32/64/128-bit). It's safe to align to 128-bit (16-bytes) for every bus width type. If buffer descriptor is improperly aligned GMAC discards lower bits of provided address and as a result reads from improper

Re: [U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

2013-09-25 Thread Vipin Kumar
On 9/25/2013 8:57 PM, Alexey Brodkin wrote: It's important that buffer descriptors are aligned in accordance to GMAC data bus width (32/64/128-bit). It's safe to align to 128-bit (16-bytes) for every bus width type. If buffer descriptor is improperly aligned GMAC discards lower bits of provided

Re: [U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

2013-09-25 Thread Mischa Jonker
Vipin wrote: I have also faced this problem before. May be a better solution is to place all the struct and buffer declarations at the very start of dw_eth_dev structure (off-course with a comment that these should not be moved). It may avoid the problem in later modifications I think that's