Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Rob Clark
On Fri, Nov 17, 2017 at 12:46 PM, Heinrich Schuchardt wrote: > On 11/17/2017 03:04 PM, Rob Clark wrote: >> >> On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt >> wrote: >>> >>> Assignments should not be made in the middle of nowhere. >>> >>>

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Heinrich Schuchardt
On 11/17/2017 03:04 PM, Rob Clark wrote: On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt wrote: Assignments should not be made in the middle of nowhere. Signed-off-by: Heinrich Schuchardt --- v2 Call efi_dp_str in debug mode only. ---

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Rob Clark
On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6

[U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-12 Thread Heinrich Schuchardt
Assignments should not be made in the middle of nowhere. Signed-off-by: Heinrich Schuchardt --- v2 Call efi_dp_str in debug mode only. --- lib/efi_loader/efi_bootmgr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git