[U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread José Miguel Gonçalves
This patch adds the support for Samsung's S3C24XX SoCs that have an ARM926EJS core. Currently it supports S3C2412, S3C2413, S3C2416 and S3C2450. Tested on an S3C2416 platform. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt --- Changes for v2: - Added register bit macros to avoid

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Marek Vasut
Dear José Miguel Gonçalves, It's getting better :) [...] + +typedef ulong(*getfreq) (void); Is this used? +static const getfreq freq_f[] = { const array const members, no? + get_FCLK, + get_HCLK, + get_PCLK, + get_UCLK, +}; + +static const char freq_c[] = { 'F',

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Marek Vasut
Dear José Miguel Gonçalves, Hi Marek, On 14-09-2012 19:03, Marek Vasut wrote: Dear José Miguel Gonçalves, It's getting better :) Hopefully :-) [...] + +typedef ulong(*getfreq) (void); Is this used? In the array declaration bellow... Why, these are only values, no

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 06:28:53PM +0100, Jos?? Miguel Gon??alves wrote: This patch adds the support for Samsung's S3C24XX SoCs that have an ARM926EJS core. Currently it supports S3C2412, S3C2413, S3C2416 and S3C2450. Tested on an S3C2416 platform. [snip] +/* + * Reset the cpu by setting

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 08:25:25PM +0200, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Marek, On 14-09-2012 19:03, Marek Vasut wrote: Dear José Miguel Gonçalves, It's getting better :) Hopefully :-) [...] + +typedef ulong(*getfreq) (void); Is

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Marek Vasut
Dear Scott Wood, On Fri, Sep 14, 2012 at 08:25:25PM +0200, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Marek, On 14-09-2012 19:03, Marek Vasut wrote: Dear José Miguel Gonçalves, It's getting better :) Hopefully :-) [...] + +typedef

Re: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 09:07:12PM +0200, Marek Vasut wrote: Dear Scott Wood, On Fri, Sep 14, 2012 at 08:25:25PM +0200, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Marek, On 14-09-2012 19:03, Marek Vasut wrote: Dear José Miguel Gonçalves, It's getting