Re: [U-Boot] [PATCH v2 04/23] arm: imx: hab: Optimise flow of authenticate_image on hab_entry fail

2017-12-29 Thread Bryan O'Donoghue
On 29/12/17 16:36, Breno Matheus Lima wrote: Secure boot enabled HAB Configuration: 0xcc, HAB State: 0x99 No HAB Events Found! => In this situation the "hab_rvt_authenticate_image()" is not executed, It's a bit confusing to receive a "No HAB Events Found!" message after running hab_auth_img

Re: [U-Boot] [PATCH v2 04/23] arm: imx: hab: Optimise flow of authenticate_image on hab_entry fail

2017-12-29 Thread Breno Matheus Lima
Hi Bryan, 2017-12-28 16:49 GMT-02:00 Bryan O'Donoghue : > The current code disjoins an entire block of code on hab_entry pass/fail > resulting in a large chunk of authenticate_image being offset to the right. > > Fix this by checking hab_entry() pass/failure and

[U-Boot] [PATCH v2 04/23] arm: imx: hab: Optimise flow of authenticate_image on hab_entry fail

2017-12-28 Thread Bryan O'Donoghue
The current code disjoins an entire block of code on hab_entry pass/fail resulting in a large chunk of authenticate_image being offset to the right. Fix this by checking hab_entry() pass/failure and exiting the function directly if in an error state. Signed-off-by: Bryan O'Donoghue