Re: [U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-06 Thread Mateusz Zalega
On 02/05/14 19:00, Marek Vasut wrote: On Wednesday, February 05, 2014 at 01:40:27 PM, Mateusz Zalega wrote: [...] Are these two new functions called from multiple places at all? If not, just inline these ll_foo() calls and be done with it. FYI you can also make macros for these to avoid

Re: [U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-06 Thread Marek Vasut
On Thursday, February 06, 2014 at 12:56:58 PM, Mateusz Zalega wrote: On 02/05/14 19:00, Marek Vasut wrote: On Wednesday, February 05, 2014 at 01:40:27 PM, Mateusz Zalega wrote: [...] Are these two new functions called from multiple places at all? If not, just inline these ll_foo()

Re: [U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-05 Thread Mateusz Zalega
On 02/05/14 08:13, Marek Vasut wrote: On Tuesday, February 04, 2014 at 06:02:38 PM, Mateusz Zalega wrote: Preprocessor definitions and hardcoded implementation selection in g_dnl core were replaced by a linker list made of (usb_function_name, bind_callback) pairs. Signed-off-by: Mateusz

Re: [U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-05 Thread Marek Vasut
On Wednesday, February 05, 2014 at 01:40:27 PM, Mateusz Zalega wrote: [...] Are these two new functions called from multiple places at all? If not, just inline these ll_foo() calls and be done with it. FYI you can also make macros for these to avoid having to type all these args all around

[U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-04 Thread Mateusz Zalega
Preprocessor definitions and hardcoded implementation selection in g_dnl core were replaced by a linker list made of (usb_function_name, bind_callback) pairs. Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Marek Vasut ma...@denx.de --- Changes

Re: [U-Boot] [PATCH v2 06/12] USB: gadget: added a saner gadget downloader registration API

2014-02-04 Thread Marek Vasut
On Tuesday, February 04, 2014 at 06:02:38 PM, Mateusz Zalega wrote: Preprocessor definitions and hardcoded implementation selection in g_dnl core were replaced by a linker list made of (usb_function_name, bind_callback) pairs. Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz