Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-21 Thread Fabio Estevam
On Thu, Aug 21, 2014 at 3:03 AM, Stefan Roese wrote: > Why don't you just use the bigger value (64) for all SoC versions? Shouldn't > hurt, right. And would keep the source clean. I think this should work fine. Thanks for the suggestion, Stefan. ___ U-

Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-21 Thread Fabio Estevam
On Thu, Aug 21, 2014 at 5:01 AM, Stefano Babic wrote: > I go just a bit further according to Otavio's comment. In this way, we > do not remove #ifdef, we have only moved. What about using is_cpu_type() > instead of this ? If you do not want to add the macro for not mx6 socs > (preferable way, I t

Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-21 Thread Stefano Babic
Hi Fabio, On 20/08/2014 23:24, Fabio Estevam wrote: > From: Fabio Estevam > > mx6solox has a requirement for 64 bytes alignment for RX DMA transfer. > > Adjust it accordingly. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Avoid too many ifdef's by providing a dma_rx_align() f

Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-20 Thread Stefan Roese
Hi Fabio, On 20.08.2014 23:24, Fabio Estevam wrote: From: Fabio Estevam mx6solox has a requirement for 64 bytes alignment for RX DMA transfer. Adjust it accordingly. Signed-off-by: Fabio Estevam --- Changes since v1: - Avoid too many ifdef's by providing a dma_rx_align() funtion as suggeste

Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-20 Thread Marek Vasut
On Wednesday, August 20, 2014 at 11:24:35 PM, Fabio Estevam wrote: > From: Fabio Estevam > > mx6solox has a requirement for 64 bytes alignment for RX DMA transfer. > > Adjust it accordingly. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Avoid too many ifdef's by providing a dm

Re: [U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-20 Thread Li Ye-B37916
Hi Fabio, I feel the name "ARCH_DMA_MINALIGN_MX6SX" is not good here. Because the 64 bytes alignment is only required by the DMA engine in FEC controller, not a ARCH DMA value. Best regards, Ye Li On 8/21/2014 5:24 AM, Fabio Estevam wrote: > From: Fabio Estevam > > mx6solox has a requirem

[U-Boot] [PATCH v2 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox

2014-08-20 Thread Fabio Estevam
From: Fabio Estevam mx6solox has a requirement for 64 bytes alignment for RX DMA transfer. Adjust it accordingly. Signed-off-by: Fabio Estevam --- Changes since v1: - Avoid too many ifdef's by providing a dma_rx_align() funtion as suggested by Otavio drivers/net/fec_mxc.c | 17 ++