Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-23 Thread Guochun Mao
On Fri, 2018-11-23 at 11:13 +0530, Jagan Teki wrote: > On Thu, Nov 22, 2018 at 2:29 PM Guochun Mao wrote: > > > > On Thu, 2018-11-22 at 11:51 +0530, Jagan Teki wrote: > > > On Wed, Nov 21, 2018 at 5:16 PM Guochun Mao > > > wrote: > > > > > > > > Hi Jagan, > > > > > > > > On Wed, 2018-11-21 at

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-22 Thread Jagan Teki
On Thu, Nov 22, 2018 at 2:29 PM Guochun Mao wrote: > > On Thu, 2018-11-22 at 11:51 +0530, Jagan Teki wrote: > > On Wed, Nov 21, 2018 at 5:16 PM Guochun Mao > > wrote: > > > > > > Hi Jagan, > > > > > > On Wed, 2018-11-21 at 15:08 +0530, Jagan Teki wrote: > > > > > > > > > > +static int

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-22 Thread Guochun Mao
On Thu, 2018-11-22 at 11:51 +0530, Jagan Teki wrote: > On Wed, Nov 21, 2018 at 5:16 PM Guochun Mao wrote: > > > > Hi Jagan, > > > > On Wed, 2018-11-21 at 15:08 +0530, Jagan Teki wrote: > > > > > > > > +static int mtk_qspi_tx_rx(struct mtk_qspi_priv *priv) > > > > > > +{ > > > > > > + int

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-21 Thread Jagan Teki
On Wed, Nov 21, 2018 at 5:16 PM Guochun Mao wrote: > > Hi Jagan, > > On Wed, 2018-11-21 at 15:08 +0530, Jagan Teki wrote: > > > > > > +static int mtk_qspi_tx_rx(struct mtk_qspi_priv *priv) > > > > > +{ > > > > > + int len = 1 + priv->txlen + priv->rxlen; > > > > > + int i, ret, idx; >

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-21 Thread Guochun Mao
Hi Jagan, On Wed, 2018-11-21 at 15:08 +0530, Jagan Teki wrote: > > > > +static int mtk_qspi_tx_rx(struct mtk_qspi_priv *priv) > > > > +{ > > > > + int len = 1 + priv->txlen + priv->rxlen; > > > > + int i, ret, idx; > > > > + > > > > + if (len > MTK_QSPI_MAX_SHIFT) > > > > +

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-21 Thread Jagan Teki
On Wed, Nov 14, 2018 at 6:23 PM Guochun Mao wrote: > > On Wed, 2018-11-14 at 14:34 +0530, Jagan Teki wrote: > > On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > > > > > From: Guochun Mao > > > > > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > > > > > Cc: Jagan Teki

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-14 Thread Guochun Mao
On Wed, 2018-11-14 at 14:34 +0530, Jagan Teki wrote: > On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > > > From: Guochun Mao > > > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > > > Cc: Jagan Teki > > Signed-off-by: Guochun Mao > > --- > > change since v2: > > -

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-14 Thread Jagan Teki
On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > From: Guochun Mao > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > Cc: Jagan Teki > Signed-off-by: Guochun Mao > --- > change since v2: > - Drop flash commands in the driver. > --- > drivers/spi/Kconfig| 7 + >

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-10-26 Thread Jagan Teki
On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > From: Guochun Mao > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > Cc: Jagan Teki > Signed-off-by: Guochun Mao > --- Few spaces need to add, will fix while applying. Reviewed-by: Jagan Teki

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-10-24 Thread Simon Glass
On 12 October 2018 at 01:01, Ryder Lee wrote: > From: Guochun Mao > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > Cc: Jagan Teki > Signed-off-by: Guochun Mao > --- > change since v2: > - Drop flash commands in the driver. > --- > drivers/spi/Kconfig| 7 + >

[U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-10-12 Thread Ryder Lee
From: Guochun Mao This patch adds MT7629 qspi driver for accessing SPI NOR flash. Cc: Jagan Teki Signed-off-by: Guochun Mao --- change since v2: - Drop flash commands in the driver. --- drivers/spi/Kconfig| 7 + drivers/spi/Makefile | 1 + drivers/spi/mtk_qspi.c | 359