Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-13 Thread Joe Hershberger
On Fri, Sep 13, 2019 at 9:31 AM Simon Glass wrote: > > Hi Ondřej, > > On Thu, 12 Sep 2019 at 17:39, Ondřej Jirman wrote: > > > > On Thu, Sep 12, 2019 at 01:28:10PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Thu, 12 Sep 2019 at 12:28, Ondřej Jirman wrote: > > > > > > > > Hi, > > > > > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-13 Thread Tom Rini
On Fri, Sep 13, 2019 at 04:34:45PM +0200, Ondřej Jirman wrote: > On Fri, Sep 13, 2019 at 08:25:09AM -0600, Simon Glass wrote: > > Hi Ondřej, > > > > On Thu, 12 Sep 2019 at 17:39, Ondřej Jirman wrote: > > > > > > On Thu, Sep 12, 2019 at 01:28:10PM -0600, Simon Glass wrote: > > > > Hi, > > > > > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-13 Thread Ondřej Jirman
On Fri, Sep 13, 2019 at 08:25:09AM -0600, Simon Glass wrote: > Hi Ondřej, > > On Thu, 12 Sep 2019 at 17:39, Ondřej Jirman wrote: > > > > On Thu, Sep 12, 2019 at 01:28:10PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Thu, 12 Sep 2019 at 12:28, Ondřej Jirman wrote: > > > > > > > > Hi, > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-13 Thread Simon Glass
Hi Ondřej, On Thu, 12 Sep 2019 at 17:39, Ondřej Jirman wrote: > > On Thu, Sep 12, 2019 at 01:28:10PM -0600, Simon Glass wrote: > > Hi, > > > > On Thu, 12 Sep 2019 at 12:28, Ondřej Jirman wrote: > > > > > > Hi, > > > > > > On Thu, Sep 12, 2019 at 12:22:15PM -0600, Simon Glass wrote: > > > > Hi,

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-12 Thread Ondřej Jirman
On Thu, Sep 12, 2019 at 01:28:10PM -0600, Simon Glass wrote: > Hi, > > On Thu, 12 Sep 2019 at 12:28, Ondřej Jirman wrote: > > > > Hi, > > > > On Thu, Sep 12, 2019 at 12:22:15PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Thu, 12 Sep 2019 at 10:59, Ondřej Jirman wrote: > > > > > > > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-12 Thread Simon Glass
Hi, On Thu, 12 Sep 2019 at 12:28, Ondřej Jirman wrote: > > Hi, > > On Thu, Sep 12, 2019 at 12:22:15PM -0600, Simon Glass wrote: > > Hi, > > > > On Thu, 12 Sep 2019 at 10:59, Ondřej Jirman wrote: > > > > > > Hello, > > > > > > On Thu, Aug 01, 2019 at 09:46:54AM -0600, Simon Glass wrote: > > > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-12 Thread Ondřej Jirman
Hi, On Thu, Sep 12, 2019 at 12:22:15PM -0600, Simon Glass wrote: > Hi, > > On Thu, 12 Sep 2019 at 10:59, Ondřej Jirman wrote: > > > > Hello, > > > > On Thu, Aug 01, 2019 at 09:46:54AM -0600, Simon Glass wrote: > > > This function fits better with the network subsystem, so move it. > > > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-12 Thread Simon Glass
Hi, On Thu, 12 Sep 2019 at 10:59, Ondřej Jirman wrote: > > Hello, > > On Thu, Aug 01, 2019 at 09:46:54AM -0600, Simon Glass wrote: > > This function fits better with the network subsystem, so move it. > > Unfortunately, this breaks builds without CONFIG_NET. Reverting it > fixes the issue. > >

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-09-12 Thread Ondřej Jirman
Hello, On Thu, Aug 01, 2019 at 09:46:54AM -0600, Simon Glass wrote: > This function fits better with the network subsystem, so move it. Unfortunately, this breaks builds without CONFIG_NET. Reverting it fixes the issue. LD u-boot cmd/built-in.o: In function `eth_env_get_enetaddr':

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-08-13 Thread Tom Rini
On Thu, Aug 01, 2019 at 09:46:54AM -0600, Simon Glass wrote: > This function fits better with the network subsystem, so move it. > > Signed-off-by: Simon Glass > Suggested-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-08-02 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 10:57 AM Simon Glass wrote: > > This function fits better with the network subsystem, so move it. > > Signed-off-by: Simon Glass > Suggested-by: Joe Hershberger Acked-by :Joe Hershberger ___ U-Boot mailing list

[U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-08-01 Thread Simon Glass
This function fits better with the network subsystem, so move it. Signed-off-by: Simon Glass Suggested-by: Joe Hershberger --- Changes in v2: - Add new patch to move eth_parse_enetaddr() to net.c/h cmd/nvedit.c | 12 include/environment.h | 2 -- include/net.h