Re: [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Alexander Graf
On 15.11.18 20:33, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 8:28 PM Alexander Graf wrote: >> On 15.11.18 18:58, Andy Shevchenko wrote: >>> Cache the value of the reg-io-width property for the future use. > >>> struct ns16550_platdata { >>> unsigned long base; >>> + int

Re: [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 9:47 PM Simon Glass wrote: > On 15 November 2018 at 09:58, Andy Shevchenko > wrote: > > Cache the value of the reg-io-width property for the future use. > > plat->reg_offset = dev_read_u32_default(dev, "reg-offset", 0); > > plat->reg_shift =

Re: [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Simon Glass
Hi Andy, On 15 November 2018 at 09:58, Andy Shevchenko wrote: > Cache the value of the reg-io-width property for the future use. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/ns16550.c | 1 + > include/ns16550.h| 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > >

Re: [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 8:28 PM Alexander Graf wrote: > On 15.11.18 18:58, Andy Shevchenko wrote: > > Cache the value of the reg-io-width property for the future use. > > struct ns16550_platdata { > > unsigned long base; > > + int reg_width; > > int reg_shift; > > - int

Re: [U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Alexander Graf
On 15.11.18 18:58, Andy Shevchenko wrote: > Cache the value of the reg-io-width property for the future use. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/ns16550.c | 1 + > include/ns16550.h| 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git

[U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

2018-11-15 Thread Andy Shevchenko
Cache the value of the reg-io-width property for the future use. Signed-off-by: Andy Shevchenko --- drivers/serial/ns16550.c | 1 + include/ns16550.h| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index