Replace Linux-like debug printout macros by native ones.
Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com
---
drivers/usb/gadget/ether.c | 99 ---
1 files changed, 46 insertions(+), 53 deletions(-)
diff --git a/drivers/usb/gadget/ether.c
On 2010/08/13 2:57 PM, Vitaly Kuzmichev wrote:
Replace Linux-like debug printout macros by native ones.
Signed-off-by: Vitaly Kuzmichevvkuzmic...@mvista.com
---
drivers/usb/gadget/ether.c | 99
---
1 files changed, 46 insertions(+), 53
Hi,
Rogan Dawes wrote:
+#define DEBUG
+#undef DEBUG
+
Eh?
Such thing is used to let someone know that this driver supports debug
output through native U-Boot macros. So one need to comment #undef to
compile ether.c with debug messages.
There are at least 67 files in U-Boot that use such
Vitaly Kuzmichev wrote:
There are at least 67 files in U-Boot that use such construction.
I was wrong.
I calculated for linux/drivers directory.
Actually 13 for u-boot.
___
U-Boot mailing list
U-Boot@lists.denx.de
Vitaly Kuzmichev wrote:
Hi,
Rogan Dawes wrote:
+#define DEBUG
+#undef DEBUG
+
Eh?
Such thing is used to let someone know that this driver supports debug
output through native U-Boot macros. So one need to comment #undef to
compile ether.c with debug messages.
There are at least 67
Hi Stefano,
Stefano Babic wrote:
If you want to remember how to set the debug output, it should be enough
to add a comments with to enable the debugging, define DEBUG before
common.h or something like that. I vote to remove only the two lines...
Would not it be better to make one of the
On 2010/08/13 3:40 PM, Vitaly Kuzmichev wrote:
Hi Stefano,
Stefano Babic wrote:
If you want to remember how to set the debug output, it should be enough
to add a comments with to enable the debugging, define DEBUG before
common.h or something like that. I vote to remove only the two lines...
Dear Vitaly Kuzmichev,
In message 1281704276-29115-1-git-send-email-vkuzmic...@mvista.com you wrote:
Replace Linux-like debug printout macros by native ones.
Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com
---
drivers/usb/gadget/ether.c | 99
Dear Vitaly Kuzmichev,
In message 4c6544b9.3000...@mvista.com you wrote:
+#define DEBUG
+#undef DEBUG
+
Eh?
Such thing is used to let someone know that this driver supports debug
output through native U-Boot macros. So one need to comment #undef to
compile ether.c with debug
Dear Vitaly Kuzmichev,
In message 4c654b30.9060...@mvista.com you wrote:
Hi Stefano,
Stefano Babic wrote:
If you want to remember how to set the debug output, it should be enough
to add a comments with to enable the debugging, define DEBUG before
common.h or something like that. I vote
Vitaly Kuzmichev wrote:
Hi Stefano,
Hi Vitaly,
Stefano Babic wrote:
If you want to remember how to set the debug output, it should be enough
to add a comments with to enable the debugging, define DEBUG before
common.h or something like that. I vote to remove only the two lines...
Would
Hello.
Vitaly Kuzmichev wrote:
Rogan Dawes wrote:
+#define DEBUG
+#undef DEBUG
+
Eh?
Such thing is used to let someone know that this driver supports debug
output through native U-Boot macros. So one need to comment #undef to
compile ether.c with debug messages.
There are at least 67
Hi,
2010/8/13 Vitaly Kuzmichev vkuzmic...@mvista.com:
Replace Linux-like debug printout macros by native ones.
Signed-off-by: Vitaly Kuzmichev vkuzmic...@mvista.com
---
drivers/usb/gadget/ether.c | 99 ---
1 files changed, 46 insertions(+), 53
Dear Stefano Babic,
In message 4c6557c5.4000...@denx.de you wrote:
It is ok, but it generates another new CONFIG_ switch, that is unusable
for the rest of u-boot. I agree that in u-boot there is a lot of
different and local functions to setup, and probably a general mechanism
should be
Dear Sergei Shtylyov,
In message 4c6558d4.9070...@mvista.com you wrote:
I'd suggest leaving just #undef DEBUG (which can be edited into #define
DEBUG if desired)...
Don't you listen? Remove that, completely, please!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH,
Dear Remy Bohmer,
In message aanlktikbeesekkuaecpzbwm3ramjkjcpkk=ykrnhw...@mail.gmail.com you
wrote:
+#define DEBUG
+#undef DEBUG
Applied to u-boot-usb/cdc branch after removing ' #define DEBUG' as
Sergei suggested.
NAK. Please also remove the dead and completely needless #undef DEBUG
Hi,
2010/8/13 Wolfgang Denk w...@denx.de:
Dear Remy Bohmer,
In message aanlktikbeesekkuaecpzbwm3ramjkjcpkk=ykrnhw...@mail.gmail.com you
wrote:
+#define DEBUG
+#undef DEBUG
Applied to u-boot-usb/cdc branch after removing ' #define DEBUG' as
Sergei suggested.
NAK. Please also remove
17 matches
Mail list logo
