Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-05 Thread Sam Protsenko
Hi Aleksandr, On Thu, Dec 5, 2019 at 4:17 AM Aleksandr Bulyshchenko wrote: > > Hello Sam, > > I'd like to add my 5 cents regarding separating dtimg start|size into 3 > subcommands >> >> dtimg start index [varname] >> dtimg start id [varname] >> dtimg start rev [varname] > > While I don't

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-05 Thread Aleksandr Bulyshchenko
Hello Sam, I'd like to add my 5 cents regarding separating dtimg start|size into 3 subcommands > dtimg start index [varname] > dtimg start id [varname] > dtimg start rev [varname] > > While I don't see real usecases for combining index with id or rev (if someone applies metainformation to

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-05 Thread Eugeniu Rosca
On Thu, Dec 05, 2019 at 04:17:38AM +0200, Aleksandr Bulyshchenko wrote: >Hello Sam, >I'd like to add my 5 cents regarding separating dtimg start|size into 3 >subcommands > > dtimg start index [varname] > dtimg start id [varname] > dtimg start rev [varname] > >While I

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Sam Protsenko
Hi, On Wed, Dec 4, 2019 at 8:25 PM Eugeniu Rosca wrote: > > Hi again, > > [I would be willing to take this discussion offline, if you consider it > too noisy for ML] > Agreed. Please find me on freenode IRC, nick: joeskb7. There is #u-boot channel, or #linaro-android, whichever suits you best.

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Sam Protsenko
Hi, On Tue, Dec 3, 2019 at 9:29 PM Eugeniu Rosca wrote: > > Hi Sam, > Cc: Aleksandr, Roman > > As expressed in the attached e-mail, to minimize the headaches extending > the argument list of "bootimg" in future, can we please agree on below? > > On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Sam Protsenko
Hi, On Wed, Dec 4, 2019 at 7:33 PM Eugeniu Rosca wrote: > > Hello Sam, > Please, see one more suggestion below. > > On Tue, Dec 03, 2019 at 08:29:10PM +0100, Eugeniu Rosca wrote: > > Hi Sam, > > Cc: Aleksandr, Roman > > > > As expressed in the attached e-mail, to minimize the headaches extending

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Eugeniu Rosca
Hi again, [I would be willing to take this discussion offline, if you consider it too noisy for ML] On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote: > +U_BOOT_CMD( > + bootimg, CONFIG_SYS_MAXARGS, 0, do_bootimg, > + "manipulate Android Boot Image", > + "set_addr \n" > +

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Eugeniu Rosca
Hello Sam, Please, see one more suggestion below. On Tue, Dec 03, 2019 at 08:29:10PM +0100, Eugeniu Rosca wrote: > Hi Sam, > Cc: Aleksandr, Roman > > As expressed in the attached e-mail, to minimize the headaches extending > the argument list of "bootimg" in future, can we please agree on below?

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-04 Thread Eugeniu Rosca
Hi Sam, On Mon, Dec 02, 2019 at 09:07:15PM +0200, Sam Protsenko wrote: > I'd like this patch series to be applied ASAP (probably before DTBO > patches you mention are merged). It's been too long as it is. Once > merged and we are unblocked w.r.t. Android boot stuff, we can then > look into DTBO

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-03 Thread Eugeniu Rosca
Hi Sam, Cc: Aleksandr, Roman As expressed in the attached e-mail, to minimize the headaches extending the argument list of "bootimg" in future, can we please agree on below? On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote: > +U_BOOT_CMD( > + bootimg, CONFIG_SYS_MAXARGS, 0,

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-12-02 Thread Sam Protsenko
Hi Eugeniu, On Wed, Nov 27, 2019 at 9:17 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote: > > +static int do_bootimg_get_dtb_file(cmd_tbl_t *cmdtp, int flag, int argc, > > +char * const argv[]) > > +{ > > +

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-11-27 Thread Eugeniu Rosca
Hi Sam, On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote: > +static int do_bootimg_get_dtb_file(cmd_tbl_t *cmdtp, int flag, int argc, > +char * const argv[]) > +{ > + char *endp; > + char buf[65]; > + u32 index; > + ulong addr; > +

Re: [U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-10-29 Thread Simon Glass
Hi Sam, On Wed, 23 Oct 2019 at 08:34, Sam Protsenko wrote: > > This command can be used to extract fields and image payloads from > Android Boot Image. It can be used for example to implement boot flow > where dtb is taken from boot.img (as v2 incorporated dtb inside of > boot.img). Using this

[U-Boot] [PATCH v2 3/8] cmd: bootimg: Add bootimg command

2019-10-23 Thread Sam Protsenko
This command can be used to extract fields and image payloads from Android Boot Image. It can be used for example to implement boot flow where dtb is taken from boot.img (as v2 incorporated dtb inside of boot.img). Using this command, one can obtain needed dtb file from boot.img in scripting