Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-07 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201104070047.28480.vap...@gentoo.org you wrote: We don't allow for CamelCaps identifiers or macro names. Macros are all caps, please. Please fix globally. these are taken straight from Linux which makes code sharing a lot easier I realized this later -

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-07 Thread Andy Fleming
On Apr 6, 2011, at 6:09 PM, Mike Frysinger wrote: On Tuesday, April 05, 2011 17:59:52 Andy Fleming wrote: -#define debug(fmt,args...) printf (fmt ,##args) +#define debug(fmt, args...) printf(fmt, ##args) it'd be nice if all these unrelated formatting changes werent intermingled. but i

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-07 Thread Wolfgang Denk
Dear Andy Fleming, In message b06395e4-2cf2-4af7-bc5b-be74508b4...@freescale.com you wrote: it'd be nice if all these unrelated formatting changes werent intermingled. but i guess too hard for you to untangle now. make it a pita to pick out what are functional changes and what

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-07 Thread Mike Frysinger
On Thu, Apr 7, 2011 at 10:16 AM, Andy Fleming wrote: On Apr 6, 2011, at 6:09 PM, Mike Frysinger wrote: On Tuesday, April 05, 2011 17:59:52 Andy Fleming wrote: -#define debug(fmt,args...)  printf (fmt ,##args) +#define debug(fmt, args...) printf(fmt, ##args) it'd be nice if all these

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-06 Thread Detlev Zundel
Hi Andy, Extends the mii_dev structure to participate in a full-blown MDIO and PHY driver scheme. The mii_dev structure and miiphy calls are modified in such a way to allow the original mii command and miiphy infrastructure to work as before, but also to support a new set of APIs which

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-06 Thread Mike Frysinger
On Tuesday, April 05, 2011 17:59:52 Andy Fleming wrote: -#define debug(fmt,args...) printf (fmt ,##args) +#define debug(fmt, args...) printf(fmt, ##args) it'd be nice if all these unrelated formatting changes werent intermingled. but i guess too hard for you to untangle now. make it a

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-06 Thread Wolfgang Denk
Dear Andy Fleming, In message 1302040794-19837-5-git-send-email-aflem...@freescale.com you wrote: Extends the mii_dev structure to participate in a full-blown MDIO and PHY driver scheme. The mii_dev structure and miiphy calls are modified in such a way to allow the original mii command and

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-06 Thread Mike Frysinger
On Thursday, April 07, 2011 00:43:44 Wolfgang Denk wrote: Andy Fleming wrote: +#define SUPPORTED_10baseT_Half (1 0) +#define SUPPORTED_10baseT_Full (1 1) +#define SUPPORTED_100baseT_Half(1 2) +#define SUPPORTED_100baseT_Full(1 3)

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-06 Thread Wolfgang Denk
Dear Andy Fleming, In message 1302040794-19837-5-git-send-email-aflem...@freescale.com you wrote: Extends the mii_dev structure to participate in a full-blown MDIO and PHY driver scheme. The mii_dev structure and miiphy calls are modified in such a way to allow the original mii command and