Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-23 Thread Haavard Skinnemoen
Mark Jackson wrote: Haavard Skinnemoen wrote: Mark Jackson wrote: We do NOT want to do everything that is possible, but only what is reasonable. Exactly ... otherwise where do you stop ? JPG, GIF, TIFF, PNG, etc ? We're *only* meant to be showing a simply boot up image (not view

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-02 Thread Haavard Skinnemoen
Mark Jackson wrote: We do NOT want to do everything that is possible, but only what is reasonable. Exactly ... otherwise where do you stop ? JPG, GIF, TIFF, PNG, etc ? We're *only* meant to be showing a simply boot up image (not view lots of different sized photos or movies !!), in a

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-01 Thread Mark Jackson
Wolfgang Denk wrote: Dear Guennadi Liakhovetski, In message pine.lnx.4.64.0901302206180.4...@axis700.grange you wrote: platform-specific types and code. So, looking at this your patch - do we really need the one more CONFIG_ define for CONFIG_BMP_16BPP? What are the drawbacks of adding

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Mark Jackson
Wolfgang Denk wrote: Dear Mark Jackson, In message 49817e75.7060...@mimc.co.uk you wrote: snip Or have I misunderstood the bmp format and the existing code ? I don't know - I'm just asking because the 16 bpp case is different from the 1 and 8 bpp cases where the operands are swapped.

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message pine.lnx.4.64.0901302206180.4...@axis700.grange you wrote: platform-specific types and code. So, looking at this your patch - do we really need the one more CONFIG_ define for CONFIG_BMP_16BPP? What are the drawbacks of adding your code

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Guennadi Liakhovetski
On Fri, 30 Jan 2009, Wolfgang Denk wrote: If we really add more bmp formats, we also get more combinations like of bmp / lcd: Not necessarily. We can always request that bitmap images match the natural color depth of the display. It makes no sense to send a 16 bpp image to a 1 bpp

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-29 Thread Mark Jackson
Wolfgang Denk wrote: Dear Mark Jackson, In message 497f1732.6050...@mimc.co.uk you wrote: This patch adds 16bpp BMP support to the common lcd code. Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. At the moment it's only been tested on the MIMC200 AVR32 board, but

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-28 Thread Wolfgang Denk
Dear Mark Jackson, In message 497f1732.6050...@mimc.co.uk you wrote: This patch adds 16bpp BMP support to the common lcd code. Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. At the moment it's only been tested on the MIMC200 AVR32 board, but extending this to

[U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-27 Thread Mark Jackson
This patch adds 16bpp BMP support to the common lcd code. Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. At the moment it's only been tested on the MIMC200 AVR32 board, but extending this to other platforms should be a simple task !! Signed-off-by: Mark Jackson